Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1873923003: Fix memory leak in SkBlurImageFilter (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/effects/SkBlurImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
robertphillips
4 years, 8 months ago (2016-04-08 21:34:34 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873923003/1
4 years, 8 months ago (2016-04-08 21:34:49 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-08 21:46:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873923003/1
4 years, 8 months ago (2016-04-08 21:50:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e6356546d8c036e32f5a03ce37161e0e790dfca4
4 years, 8 months ago (2016-04-08 21:52:55 UTC) #12
Stephen White
Interesting. Would making asTextureRef() return an sk_sp<GrTexture> help to avoid this in the future?
4 years, 8 months ago (2016-04-11 14:25:18 UTC) #13
robertphillips
4 years, 8 months ago (2016-04-11 14:32:34 UTC) #14
Message was sent while issue was closed.
On 2016/04/11 14:25:18, Stephen White wrote:
> Interesting. Would making asTextureRef() return an sk_sp<GrTexture> help to
> avoid this in the future?

I think we will move in that direction but I think that is further out.

Powered by Google App Engine
This is Rietveld 408576698