Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1843)

Unified Diff: src/ports/SkFontMgr_fontconfig.cpp

Issue 1873923002: Begin switch to SkFontStyle for legacy calls. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Dont update bzl file now. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ports/SkFontMgr_custom.cpp ('k') | src/ports/SkFontMgr_win_dw.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ports/SkFontMgr_fontconfig.cpp
diff --git a/src/ports/SkFontMgr_fontconfig.cpp b/src/ports/SkFontMgr_fontconfig.cpp
index 089be5cdbe16eeeeeddc390ab9380609a2a53fb4..c8b055f779678d5737ea12f8779ff31a4de01eca 100644
--- a/src/ports/SkFontMgr_fontconfig.cpp
+++ b/src/ports/SkFontMgr_fontconfig.cpp
@@ -264,10 +264,6 @@ static int map_range(SkFixed value,
return new_min + SkMulDiv(value - old_min, new_max - new_min, old_max - old_min);
}
-static int ave(SkFixed a, SkFixed b) {
- return SkFixedAve(a, b);
-}
-
struct MapRanges {
SkFixed old_val;
SkFixed new_val;
@@ -279,15 +275,11 @@ static SkFixed map_ranges_fixed(SkFixed val, MapRanges const ranges[], int range
return ranges[0].new_val;
}
- // Linear from [i] to ave([i], [i+1]), then from ave([i], [i+1]) to [i+1]
+ // Linear from [i] to [i+1]
for (int i = 0; i < rangesCount - 1; ++i) {
- if (val < ave(ranges[i].old_val, ranges[i+1].old_val)) {
- return map_range(val, ranges[i].old_val, ave(ranges[i].old_val, ranges[i+1].old_val),
- ranges[i].new_val, ave(ranges[i].new_val, ranges[i+1].new_val));
- }
if (val < ranges[i+1].old_val) {
- return map_range(val, ave(ranges[i].old_val, ranges[i+1].old_val), ranges[i+1].old_val,
- ave(ranges[i].new_val, ranges[i+1].new_val), ranges[i+1].new_val);
+ return map_range(val, ranges[i].old_val, ranges[i+1].old_val,
+ ranges[i].new_val, ranges[i+1].new_val);
}
}
@@ -882,15 +874,12 @@ protected:
return new SkTypeface_stream(fontData, style, isFixedWidth);
}
- virtual SkTypeface* onLegacyCreateTypeface(const char familyName[],
- unsigned styleBits) const override {
- bool bold = styleBits & SkTypeface::kBold;
- bool italic = styleBits & SkTypeface::kItalic;
- SkFontStyle style = SkFontStyle(bold ? SkFontStyle::kBold_Weight
- : SkFontStyle::kNormal_Weight,
- SkFontStyle::kNormal_Width,
- italic ? SkFontStyle::kItalic_Slant
- : SkFontStyle::kUpright_Slant);
+#ifdef SK_VERY_LEGACY_CREATE_TYPEFACE
+ SkTypeface* onLegacyCreateTypeface(const char familyName[], unsigned styleBits) const override {
+ SkFontStyle style = SkFontStyle::FromOldStyle(styleBits);
+#else
+ SkTypeface* onLegacyCreateTypeface(const char familyName[], SkFontStyle style) const override {
+#endif
SkAutoTUnref<SkTypeface> typeface(this->matchFamilyStyle(familyName, style));
if (typeface.get()) {
return typeface.release();
« no previous file with comments | « src/ports/SkFontMgr_custom.cpp ('k') | src/ports/SkFontMgr_win_dw.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698