Begin switch to SkFontStyle for legacy calls.

include/core/SkFontStyle.h

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkFontStyle_DEFINED
 #define SkFontStyle_DEFINED
 
@@ skipping 25 matching lines @@
         kUltaExpanded_Width     = 9
     };
 
     enum Slant {
         kUpright_Slant,
         kItalic_Slant,
     };
 
     SkFontStyle();
     SkFontStyle(int weight, int width, Slant);
-    /** oldStyle means the style-bits in SkTypeface::Style: bold=1, italic=2 */
-    explicit SkFontStyle(unsigned oldStyle);
+
+    static SkFontStyle FromOldStyle(unsigned oldStyle);
+
+    explicit SkFontStyle(uint32_t d)

[dogben, 2016/04/11 20:28:58]

I don't see anywhere you use the uint32_t constructor or operator uint32_t().

It seems a little scary to be removing an int constructor and also adding
another int constructor that does something completely different.

[bungeman-skia, 2016/04/11 21:55:52]

This was done to make the Chromium side IPC change as small as possible.I may
end up being able to remove it.

Done.

+        : SkFontStyle(Data{d}.fR.fWeight, Data{d}.fR.fWidth, static_cast<Slant>(Data{d}.fR.fSlant))
+    {}
+    explicit operator uint32_t() { return fUnion.fU32; }
 
     bool operator==(const SkFontStyle& rhs) const {
         return fUnion.fU32 == rhs.fUnion.fU32;
     }
 
     int weight() const { return fUnion.fR.fWeight; }
     int width() const { return fUnion.fR.fWidth; }
     Slant slant() const { return (Slant)fUnion.fR.fSlant; }
 
     bool isItalic() const {
         return kItalic_Slant == fUnion.fR.fSlant;
     }
 
 private:
-    union {
+    union Data {
+        uint32_t    fU32;
         struct {
             uint16_t fWeight;   // 100 .. 900
             uint8_t  fWidth;    // 1 .. 9
             uint8_t  fSlant;    // 0 .. 2
         } fR;
-        uint32_t    fU32;
     } fUnion;
 };
 
 #endif