Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1873833002: [elements] Add more tests to increase coverage (Closed)

Created:
4 years, 8 months ago by Camillo Bruni
Modified:
4 years, 8 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[elements] Add more tests to increase coverage BUG= Committed: https://crrev.com/a6fd69ac29dd77628572b60701cc2c92544cc712 Cr-Commit-Position: refs/heads/master@{#35371}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -44 lines) Patch
M test/mjsunit/array-push.js View 1 chunk +13 lines, -0 lines 0 comments Download
M test/mjsunit/array-splice.js View 3 chunks +49 lines, -44 lines 2 comments Download
M test/mjsunit/delete.js View 1 chunk +14 lines, -0 lines 0 comments Download
M test/mjsunit/string-wrapper.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Camillo Bruni
PTAL
4 years, 8 months ago (2016-04-08 15:05:00 UTC) #2
neis
lgtm https://codereview.chromium.org/1873833002/diff/1/test/mjsunit/array-splice.js File test/mjsunit/array-splice.js (left): https://codereview.chromium.org/1873833002/diff/1/test/mjsunit/array-splice.js#oldcode425 test/mjsunit/array-splice.js:425: Ok now I see that you only moved ...
4 years, 8 months ago (2016-04-08 15:21:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873833002/1
4 years, 8 months ago (2016-04-11 07:52:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 08:27:06 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 08:28:26 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a6fd69ac29dd77628572b60701cc2c92544cc712
Cr-Commit-Position: refs/heads/master@{#35371}

Powered by Google App Engine
This is Rietveld 408576698