Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 187383007: Mojo: Replace TestWithIOThreadBase with just a helper TestIOThread class. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Replace TestWithIOThreadBase with just a helper TestIOThread class. This makes "adding" an I/O thread easier (and usable when you already have a test base class). R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255196

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -71 lines) Patch
M mojo/system/embedder/embedder_unittest.cc View 4 chunks +20 lines, -7 lines 0 comments Download
M mojo/system/raw_channel_unittest.cc View 15 chunks +27 lines, -26 lines 0 comments Download
M mojo/system/remote_message_pipe_posix_unittest.cc View 10 chunks +19 lines, -16 lines 0 comments Download
M mojo/system/test_utils.h View 2 chunks +9 lines, -13 lines 0 comments Download
M mojo/system/test_utils.cc View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-05 22:14:18 UTC) #1
sky
LGTM
6 years, 9 months ago (2014-03-05 22:16:10 UTC) #2
viettrungluu
6 years, 9 months ago (2014-03-06 01:14:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r255196 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698