Issue 187383007: Mojo: Replace TestWithIOThreadBase with just a helper TestIOThread class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187383007: Mojo: Replace TestWithIOThreadBase with just a helper TestIOThread class. (Closed)

Created:
6 years, 9 months ago by viettrungluu

Modified:
6 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Mojo: Replace TestWithIOThreadBase with just a helper TestIOThread class. This makes "adding" an I/O thread easier (and usable when you already have a test base class). R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255196

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -71 lines)			Patch
M	mojo/system/embedder/embedder_unittest.cc	View	4 chunks	+20 lines, -7 lines	0 comments	Download
M	mojo/system/raw_channel_unittest.cc	View	15 chunks	+27 lines, -26 lines	0 comments	Download
M	mojo/system/remote_message_pipe_posix_unittest.cc	View	10 chunks	+19 lines, -16 lines	0 comments	Download
M	mojo/system/test_utils.h	View	2 chunks	+9 lines, -13 lines	0 comments	Download
M	mojo/system/test_utils.cc	View	1 chunk	+3 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

viettrungluu

6 years, 9 months ago (2014-03-06 01:14:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r255196 (presubmit successful).