Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1873823002: Update elements, nodes and visitors for serialization. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fix LocalVariableElementZ.constant Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
index 1afb9d3ac23da303625ba9ada545a4f5f58ddbd5..00b88dc6b7cc804c11058b40fa0dc9d4604eba92 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
@@ -3437,11 +3437,12 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
/// Lookup the value of the enum described by [node].
getEnumValue(ast.Node node, EnumClassElement enumClass, List values) {
Element element = elements[node];
- if (element is! FieldElement || element.enclosingClass != enumClass) {
+ if (element is! EnumConstantElement ||
+ element.enclosingClass != enumClass) {
internalError(node, 'expected a JsBuiltin enum value');
}
-
- int index = enumClass.enumValues.indexOf(element);
+ EnumConstantElement enumConstant = element;
+ int index = enumConstant.index;
return values[index];
}
« no previous file with comments | « no previous file | pkg/compiler/lib/src/elements/elements.dart » ('j') | pkg/compiler/lib/src/elements/modelx.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698