Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1873823002: Update elements, nodes and visitors for serialization. (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update elements, nodes and visitors for serialization. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/4080c1b410d36d12800ae0a62ee70a93e0c63202

Patch Set 1 #

Patch Set 2 : Fix LocalVariableElementZ.constant #

Total comments: 4

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -43 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 2 1 chunk +10 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 2 7 chunks +40 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/elements/visitor.dart View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 2 8 chunks +42 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 2 3 chunks +54 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 1 2 6 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/tree/prettyprint.dart View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/tree/unparser.dart View 1 2 2 chunks +8 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Johnni Winther
4 years, 8 months ago (2016-04-08 14:40:35 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1873823002/diff/20001/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/1873823002/diff/20001/pkg/compiler/lib/src/elements/modelx.dart#newcode2897 pkg/compiler/lib/src/elements/modelx.dart:2897: SourceSpan get sourcePosition => enclosingClass.sourcePosition; why don't we ...
4 years, 8 months ago (2016-04-08 16:18:24 UTC) #3
Johnni Winther
https://codereview.chromium.org/1873823002/diff/20001/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/1873823002/diff/20001/pkg/compiler/lib/src/elements/modelx.dart#newcode2897 pkg/compiler/lib/src/elements/modelx.dart:2897: SourceSpan get sourcePosition => enclosingClass.sourcePosition; On 2016/04/08 16:18:24, Siggi ...
4 years, 8 months ago (2016-04-11 08:18:24 UTC) #4
Johnni Winther
Committed patchset #3 (id:40001) manually as 4080c1b410d36d12800ae0a62ee70a93e0c63202 (presubmit successful).
4 years, 8 months ago (2016-04-11 08:34:08 UTC) #6
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1873823002/diff/20001/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/1873823002/diff/20001/pkg/compiler/lib/src/elements/modelx.dart#newcode2897 pkg/compiler/lib/src/elements/modelx.dart:2897: SourceSpan get sourcePosition => enclosingClass.sourcePosition; On 2016/04/11 08:18:24, Johnni ...
4 years, 8 months ago (2016-04-11 16:28:18 UTC) #7
Johnni Winther
4 years, 8 months ago (2016-04-12 07:26:29 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/1873823002/diff/20001/pkg/compiler/lib/src/el...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/1873823002/diff/20001/pkg/compiler/lib/src/el...
pkg/compiler/lib/src/elements/modelx.dart:2897: SourceSpan get sourcePosition =>
enclosingClass.sourcePosition;
On 2016/04/11 16:28:18, Siggi Cherem (dart-lang) wrote:
> On 2016/04/11 08:18:24, Johnni Winther wrote:
> > On 2016/04/08 16:18:24, Siggi Cherem (dart-lang) wrote:
> > > why don't we keep the source-position of the enum-member instead?
> > 
> > The enum fields are the synthetic `index` and `values` fields. These should
> > point the enum and not any of the values.
> 
> Not sure I followed. If I write:
> 
> enum C {
>   v1,
>   v2
> }
> 
> 
> Are you saying that C.index and C.values are modeled here, but C.v1 and C.v2
are
> modeled below in EnumConstantElementX?
> 
> If so - let's add comments to both of these classes to clarify (and
> EnumConstantElement in elements.dart)

Yes. I'll update the comments.

Powered by Google App Engine
This is Rietveld 408576698