content/renderer/notification_permission_dispatcher.cc - Issue 1873783003: Convert //content/renderer from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/notification_permission_dispatcher.cc

Issue 1873783003: Convert //content/renderer from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/notification_permission_dispatcher.h ('k') | content/renderer/p2p/filtering_network_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/notification_permission_dispatcher.cc

diff --git a/content/renderer/notification_permission_dispatcher.cc b/content/renderer/notification_permission_dispatcher.cc

index f4ce9d40c87fedb2d96dae0fdb4ff7eb305cf678..110afc0810083578b2734472ce2c93b1ac88a4d6 100644

--- a/content/renderer/notification_permission_dispatcher.cc

+++ b/content/renderer/notification_permission_dispatcher.cc

@@ -31,7 +31,7 @@ void NotificationPermissionDispatcher::RequestPermission(

mojo::GetProxy(&permission_service_));

}

- scoped_ptr<WebNotificationPermissionCallback> owned_callback(callback);

+ std::unique_ptr<WebNotificationPermissionCallback> owned_callback(callback);

// base::Unretained is safe here because the Mojo channel, with associated

// callbacks, will be deleted before the "this" instance is deleted.

@@ -43,7 +43,7 @@ void NotificationPermissionDispatcher::RequestPermission(

}

void NotificationPermissionDispatcher::OnPermissionRequestComplete(

- scoped_ptr<WebNotificationPermissionCallback> callback,

+ std::unique_ptr<WebNotificationPermissionCallback> callback,

blink::mojom::PermissionStatus status) {

DCHECK(callback);