content/renderer/java/gin_java_function_invocation_helper.h - Issue 1873783003: Convert //content/renderer from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/java/gin_java_function_invocation_helper.h

Issue 1873783003: Convert //content/renderer from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/java/gin_java_bridge_value_converter_unittest.cc ('k') | content/renderer/java/gin_java_function_invocation_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/java/gin_java_function_invocation_helper.h

diff --git a/content/renderer/java/gin_java_function_invocation_helper.h b/content/renderer/java/gin_java_function_invocation_helper.h

index 823420d568435c3b05b40f6713bc9f7e213170d9..b74083c0bca5c5b0b57677e075cb30818e3486e4 100644

--- a/content/renderer/java/gin_java_function_invocation_helper.h

+++ b/content/renderer/java/gin_java_function_invocation_helper.h

@@ -5,8 +5,9 @@

#ifndef CONTENT_RENDERER_JAVA_GIN_JAVA_FUNCTION_INVOCATION_HELPER_H_

#define CONTENT_RENDERER_JAVA_GIN_JAVA_FUNCTION_INVOCATION_HELPER_H_

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "content/renderer/java/gin_java_bridge_dispatcher.h"

#include "gin/arguments.h"

@@ -28,7 +29,7 @@ class GinJavaFunctionInvocationHelper {

private:

std::string method_name_;

base::WeakPtr<GinJavaBridgeDispatcher> dispatcher_;

- scoped_ptr<GinJavaBridgeValueConverter> converter_;

+ std::unique_ptr<GinJavaBridgeValueConverter> converter_;

DISALLOW_COPY_AND_ASSIGN(GinJavaFunctionInvocationHelper);

};