Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1873763002:
gpu: Disable framebuffer discard on NVIDIA, Android, ChromeOS and Linux (Closed)
|
Created:
4 years, 8 months ago by Kimmo Kinnunen Modified:
4 years, 8 months ago CC:
chromium-reviews, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiongpu: Disable framebuffer discard on NVIDIA, Android, ChromeOS and Linux
Disable framebuffer discard on NVIDIA devices. "Kepler" architecture is
non-tiling for the most part, and does not benefit greatly from
framebuffer discard.
There also was a bug in framebuffer discard that would lock up the
system, if it was done on framebuffer with mixed samples (N:M, N != M,
N=color samples, M=stencil samples). The bug was fixed ~year ago.
Disable it for "Kepler" based devices by filtering with GLES 3.0 and
later versions. Devices with chips of earlier architectures will
probably not get GLES 3.0.
Add so many entries:
1) Disable on Linux GL devices (imitate disabling on desktop Windows
rule)
2) Disable on Linux GLES 3.0 devices
3) Disable on ChromeOS GLES 3.0 devices
4) Disable on Android GLES 3.0 devices
BUG=601753
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/a5ef831af7c5f339a22dcefac50f9bdae8788c36
Cr-Commit-Position: refs/heads/master@{#387294}
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 16 (10 generated)
Description was changed from ========== gpu: Disable framebuffer discard on NVIDIA, Android, ChromeOS and Linux Disable framebuffer discard on NVIDIA devices. "Kepler" architecture is non-tiling for the most part, and does not benefit greatly from framebuffer discard. There also was a bug in framebuffer discard that would lock up the system, if it was done on framebuffer with mixed samples (N:M, N != M, N=color samples, M=stencil samples). The bug was fixed ~year ago. Disable it for "Kepler" based devices by filtering with GLES 3.0 and later versions. Devices with chips of earlier architectures will probably not get GLES 3.0. Add so many entries: 1) Disable on Linux GL devices (imitate disabling on desktop Windows rule) 2) Disable on Linux GLES 3.0 devices 3) Disable on ChromeOS GLES 3.0 devices 4) Disable on Android GLES 3.0 devices BUG=601753 ========== to ========== gpu: Disable framebuffer discard on NVIDIA, Android, ChromeOS and Linux Disable framebuffer discard on NVIDIA devices. "Kepler" architecture is non-tiling for the most part, and does not benefit greatly from framebuffer discard. There also was a bug in framebuffer discard that would lock up the system, if it was done on framebuffer with mixed samples (N:M, N != M, N=color samples, M=stencil samples). The bug was fixed ~year ago. Disable it for "Kepler" based devices by filtering with GLES 3.0 and later versions. Devices with chips of earlier architectures will probably not get GLES 3.0. Add so many entries: 1) Disable on Linux GL devices (imitate disabling on desktop Windows rule) 2) Disable on Linux GLES 3.0 devices 3) Disable on ChromeOS GLES 3.0 devices 4) Disable on Android GLES 3.0 devices BUG=601753 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== gpu: Disable framebuffer discard on NVIDIA, Android, ChromeOS and Linux Disable framebuffer discard on NVIDIA devices. "Kepler" architecture is non-tiling for the most part, and does not benefit greatly from framebuffer discard. There also was a bug in framebuffer discard that would lock up the system, if it was done on framebuffer with mixed samples (N:M, N != M, N=color samples, M=stencil samples). The bug was fixed ~year ago. Disable it for "Kepler" based devices by filtering with GLES 3.0 and later versions. Devices with chips of earlier architectures will probably not get GLES 3.0. Add so many entries: 1) Disable on Linux GL devices (imitate disabling on desktop Windows rule) 2) Disable on Linux GLES 3.0 devices 3) Disable on ChromeOS GLES 3.0 devices 4) Disable on Android GLES 3.0 devices BUG=601753 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: Disable framebuffer discard on NVIDIA, Android, ChromeOS and Linux Disable framebuffer discard on NVIDIA devices. "Kepler" architecture is non-tiling for the most part, and does not benefit greatly from framebuffer discard. There also was a bug in framebuffer discard that would lock up the system, if it was done on framebuffer with mixed samples (N:M, N != M, N=color samples, M=stencil samples). The bug was fixed ~year ago. Disable it for "Kepler" based devices by filtering with GLES 3.0 and later versions. Devices with chips of earlier architectures will probably not get GLES 3.0. Add so many entries: 1) Disable on Linux GL devices (imitate disabling on desktop Windows rule) 2) Disable on Linux GLES 3.0 devices 3) Disable on ChromeOS GLES 3.0 devices 4) Disable on Android GLES 3.0 devices BUG=601753 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kkinnunen@nvidia.com changed reviewers: + zmo@chromium.org
The CQ bit was checked by kkinnunen@nvidia.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873763002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
piman@chromium.org changed reviewers: + piman@chromium.org
lgtm
The CQ bit was checked by kkinnunen@nvidia.com
The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org Link to the patchset: https://chromiumcodereview.appspot.com/1873763002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873763002/20001
Message was sent while issue was closed.
Description was changed from ========== gpu: Disable framebuffer discard on NVIDIA, Android, ChromeOS and Linux Disable framebuffer discard on NVIDIA devices. "Kepler" architecture is non-tiling for the most part, and does not benefit greatly from framebuffer discard. There also was a bug in framebuffer discard that would lock up the system, if it was done on framebuffer with mixed samples (N:M, N != M, N=color samples, M=stencil samples). The bug was fixed ~year ago. Disable it for "Kepler" based devices by filtering with GLES 3.0 and later versions. Devices with chips of earlier architectures will probably not get GLES 3.0. Add so many entries: 1) Disable on Linux GL devices (imitate disabling on desktop Windows rule) 2) Disable on Linux GLES 3.0 devices 3) Disable on ChromeOS GLES 3.0 devices 4) Disable on Android GLES 3.0 devices BUG=601753 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: Disable framebuffer discard on NVIDIA, Android, ChromeOS and Linux Disable framebuffer discard on NVIDIA devices. "Kepler" architecture is non-tiling for the most part, and does not benefit greatly from framebuffer discard. There also was a bug in framebuffer discard that would lock up the system, if it was done on framebuffer with mixed samples (N:M, N != M, N=color samples, M=stencil samples). The bug was fixed ~year ago. Disable it for "Kepler" based devices by filtering with GLES 3.0 and later versions. Devices with chips of earlier architectures will probably not get GLES 3.0. Add so many entries: 1) Disable on Linux GL devices (imitate disabling on desktop Windows rule) 2) Disable on Linux GLES 3.0 devices 3) Disable on ChromeOS GLES 3.0 devices 4) Disable on Android GLES 3.0 devices BUG=601753 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== gpu: Disable framebuffer discard on NVIDIA, Android, ChromeOS and Linux Disable framebuffer discard on NVIDIA devices. "Kepler" architecture is non-tiling for the most part, and does not benefit greatly from framebuffer discard. There also was a bug in framebuffer discard that would lock up the system, if it was done on framebuffer with mixed samples (N:M, N != M, N=color samples, M=stencil samples). The bug was fixed ~year ago. Disable it for "Kepler" based devices by filtering with GLES 3.0 and later versions. Devices with chips of earlier architectures will probably not get GLES 3.0. Add so many entries: 1) Disable on Linux GL devices (imitate disabling on desktop Windows rule) 2) Disable on Linux GLES 3.0 devices 3) Disable on ChromeOS GLES 3.0 devices 4) Disable on Android GLES 3.0 devices BUG=601753 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: Disable framebuffer discard on NVIDIA, Android, ChromeOS and Linux Disable framebuffer discard on NVIDIA devices. "Kepler" architecture is non-tiling for the most part, and does not benefit greatly from framebuffer discard. There also was a bug in framebuffer discard that would lock up the system, if it was done on framebuffer with mixed samples (N:M, N != M, N=color samples, M=stencil samples). The bug was fixed ~year ago. Disable it for "Kepler" based devices by filtering with GLES 3.0 and later versions. Devices with chips of earlier architectures will probably not get GLES 3.0. Add so many entries: 1) Disable on Linux GL devices (imitate disabling on desktop Windows rule) 2) Disable on Linux GLES 3.0 devices 3) Disable on ChromeOS GLES 3.0 devices 4) Disable on Android GLES 3.0 devices BUG=601753 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a5ef831af7c5f339a22dcefac50f9bdae8788c36 Cr-Commit-Position: refs/heads/master@{#387294} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a5ef831af7c5f339a22dcefac50f9bdae8788c36 Cr-Commit-Position: refs/heads/master@{#387294} |
