Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1873733003: More cleanup in the Vulkan viewer (Closed)

Created:
4 years, 8 months ago by jvanverth1
Modified:
4 years, 8 months ago
Reviewers:
egdaniel, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

More cleanup in the Vulkan viewer * add animation support for GMs * don't load all SkPictures at start, only as needed * don't update constantly, only for animation or stats * hide/show stats * scale slides up/down BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1873733003 Committed: https://skia.googlesource.com/skia/+/c265a92741a8deee8adb62bb20c756b46672a11c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -81 lines) Patch
M gm/scaledstrokes.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/vulkan/Window.h View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/vulkan/Window.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tools/vulkan/viewer/GMSlide.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/vulkan/viewer/GMSlide.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/vulkan/viewer/SKPSlide.h View 1 chunk +4 lines, -1 line 0 comments Download
M tools/vulkan/viewer/SKPSlide.cpp View 1 chunk +36 lines, -10 lines 0 comments Download
M tools/vulkan/viewer/Slide.h View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/vulkan/viewer/VulkanViewer.h View 2 chunks +17 lines, -1 line 0 comments Download
M tools/vulkan/viewer/VulkanViewer.cpp View 1 6 chunks +135 lines, -63 lines 0 comments Download
M tools/vulkan/win/Window_win.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/vulkan/win/Window_win.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/vulkan/win/main_win.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jvanverth1
4 years, 8 months ago (2016-04-08 18:25:31 UTC) #4
egdaniel
lgtm plus comment https://codereview.chromium.org/1873733003/diff/1/tools/vulkan/viewer/VulkanViewer.cpp File tools/vulkan/viewer/VulkanViewer.cpp (right): https://codereview.chromium.org/1873733003/diff/1/tools/vulkan/viewer/VulkanViewer.cpp#newcode188 tools/vulkan/viewer/VulkanViewer.cpp:188: //m.postTranslate(fOffset.fX, fOffset.fY); maybe add a comment ...
4 years, 8 months ago (2016-04-08 19:01:50 UTC) #5
jvanverth1
https://codereview.chromium.org/1873733003/diff/1/tools/vulkan/viewer/VulkanViewer.cpp File tools/vulkan/viewer/VulkanViewer.cpp (right): https://codereview.chromium.org/1873733003/diff/1/tools/vulkan/viewer/VulkanViewer.cpp#newcode188 tools/vulkan/viewer/VulkanViewer.cpp:188: //m.postTranslate(fOffset.fX, fOffset.fY); On 2016/04/08 19:01:50, egdaniel wrote: > maybe ...
4 years, 8 months ago (2016-04-08 19:39:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873733003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873733003/20001
4 years, 8 months ago (2016-04-08 19:39:29 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 19:51:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c265a92741a8deee8adb62bb20c756b46672a11c

Powered by Google App Engine
This is Rietveld 408576698