Issue 1873723002: Correct a tree hash to a commit hash in dartium DEPS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1873723002: Correct a tree hash to a commit hash in dartium DEPS (Closed)

Created:
4 years, 8 months ago by Bill Hesse

Modified:
4 years, 8 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Correct a tree hash to a commit hash in dartium DEPS BUG= Committed: https://github.com/dart-lang/sdk/commit/579d7c4aea6ec31736f7f97dbedaf144f91018f7

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/deps/dartium.deps/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

Committed patchset #1 (id:1) manually as 579d7c4aea6ec31736f7f97dbedaf144f91018f7 (presubmit successful).

4 years, 8 months ago (2016-04-08 09:46:30 UTC) #4

Jacob

4 years, 8 months ago (2016-04-08 16:20:35 UTC) #5

Message was sent while issue was closed.

Does 
https://chromium.googlesource.com/dart/dartium/src.git/+/releases/2454_work
give the wrong hash?
It is showing 
3e73f15498d6f3987be75cefff9565d0aa994736

which is what I entered.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages