Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: runtime/vm/flow_graph_compiler.cc

Issue 18737004: List class was not initialized properly (it has type parameters). Do not preinitialize it incorrect… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX.
6 6
7 #include "vm/flow_graph_compiler.h" 7 #include "vm/flow_graph_compiler.h"
8 8
9 #include "vm/cha.h" 9 #include "vm/cha.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 static_calls_target_table_(GrowableObjectArray::ZoneHandle( 80 static_calls_target_table_(GrowableObjectArray::ZoneHandle(
81 GrowableObjectArray::New())), 81 GrowableObjectArray::New())),
82 is_optimizing_(is_optimizing), 82 is_optimizing_(is_optimizing),
83 may_reoptimize_(false), 83 may_reoptimize_(false),
84 double_class_(Class::ZoneHandle( 84 double_class_(Class::ZoneHandle(
85 Isolate::Current()->object_store()->double_class())), 85 Isolate::Current()->object_store()->double_class())),
86 float32x4_class_(Class::ZoneHandle( 86 float32x4_class_(Class::ZoneHandle(
87 Isolate::Current()->object_store()->float32x4_class())), 87 Isolate::Current()->object_store()->float32x4_class())),
88 uint32x4_class_(Class::ZoneHandle( 88 uint32x4_class_(Class::ZoneHandle(
89 Isolate::Current()->object_store()->uint32x4_class())), 89 Isolate::Current()->object_store()->uint32x4_class())),
90 list_class_(Class::ZoneHandle(
91 Library::Handle(Library::CoreLibrary()).
92 LookupClass(Symbols::List()))),
90 parallel_move_resolver_(this), 93 parallel_move_resolver_(this),
91 pending_deoptimization_env_(NULL) { 94 pending_deoptimization_env_(NULL) {
92 ASSERT(assembler != NULL); 95 ASSERT(assembler != NULL);
96 ASSERT(!list_class_.IsNull());
93 } 97 }
94 98
95 99
96 bool FlowGraphCompiler::HasFinally() const { 100 bool FlowGraphCompiler::HasFinally() const {
97 return parsed_function().function().has_finally(); 101 return parsed_function().function().has_finally();
98 } 102 }
99 103
100 104
101 void FlowGraphCompiler::InitCompiler() { 105 void FlowGraphCompiler::InitCompiler() {
102 pc_descriptors_list_ = new DescriptorList(64); 106 pc_descriptors_list_ = new DescriptorList(64);
(...skipping 990 matching lines...) Expand 10 before | Expand all | Expand 10 after
1093 1097
1094 for (int i = 0; i < len; i++) { 1098 for (int i = 0; i < len; i++) {
1095 sorted->Add(CidTarget(ic_data.GetReceiverClassIdAt(i), 1099 sorted->Add(CidTarget(ic_data.GetReceiverClassIdAt(i),
1096 &Function::ZoneHandle(ic_data.GetTargetAt(i)), 1100 &Function::ZoneHandle(ic_data.GetTargetAt(i)),
1097 ic_data.GetCountAt(i))); 1101 ic_data.GetCountAt(i)));
1098 } 1102 }
1099 sorted->Sort(HighestCountFirst); 1103 sorted->Sort(HighestCountFirst);
1100 } 1104 }
1101 1105
1102 } // namespace dart 1106 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698