Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Issue 1873693002: Do not advance beyond the closing tag length in xmlParseEndTag2 (Closed)

Created:
4 years, 8 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@cr595262
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not advance beyond the closing tag length in xmlParseEndTag2 BUG=593690, 595262 TEST=libxml_xml_read_memory_fuzzer Committed: https://crrev.com/27a27edb43e42023db7d154dcd9f66a500296cc1 Cr-Commit-Position: refs/heads/master@{#388137}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use patch from upstream bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/libxml/README.chromium View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libxml/src/parser.c View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
dominicc (has gone to gerrit)
PTAL
4 years, 8 months ago (2016-04-08 07:01:57 UTC) #2
scottmg
lgtm https://codereview.chromium.org/1873693002/diff/1/third_party/libxml/README.chromium File third_party/libxml/README.chromium (right): https://codereview.chromium.org/1873693002/diff/1/third_party/libxml/README.chromium#newcode18 third_party/libxml/README.chromium:18: - Add patch from https://bugs.chromium.org/p/chromium/issues/detail?id=595262#c13 I can't see ...
4 years, 8 months ago (2016-04-08 14:42:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873693002/1
4 years, 8 months ago (2016-04-11 08:34:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/208721)
4 years, 8 months ago (2016-04-11 09:01:55 UTC) #7
dominicc (has gone to gerrit)
Scott, could I get you to take another look at this? I adopted a patch ...
4 years, 8 months ago (2016-04-17 13:00:18 UTC) #8
dominicc (has gone to gerrit)
On 2016/04/17 at 13:00:18, dominicc wrote: > Scott, could I get you to take another ...
4 years, 8 months ago (2016-04-18 00:43:16 UTC) #9
scottmg
lgtm
4 years, 8 months ago (2016-04-18 16:33:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873693002/20001
4 years, 8 months ago (2016-04-19 03:40:21 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 04:46:51 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 04:48:10 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27a27edb43e42023db7d154dcd9f66a500296cc1
Cr-Commit-Position: refs/heads/master@{#388137}

Powered by Google App Engine
This is Rietveld 408576698