chrome/browser/sync_file_system/local/syncable_file_operation_runner.cc - Issue 1873683002: Convert //chrome/browser/sync_file_system from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/local/syncable_file_operation_runner.cc

Issue 1873683002: Convert //chrome/browser/sync_file_system from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/local/syncable_file_operation_runner.h ('k') | chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/local/syncable_file_operation_runner.cc

diff --git a/chrome/browser/sync_file_system/local/syncable_file_operation_runner.cc b/chrome/browser/sync_file_system/local/syncable_file_operation_runner.cc

index de4e3169c20e5f219c6f9ceda0e595d9c5efbde0..cee876d395bcadb70e430819f264aa51a6372d42 100644

--- a/chrome/browser/sync_file_system/local/syncable_file_operation_runner.cc

+++ b/chrome/browser/sync_file_system/local/syncable_file_operation_runner.cc

@@ -68,7 +68,8 @@ void SyncableFileOperationRunner::OnWriteEnabled(const FileSystemURL& url) {

RunNextRunnableTask();

}

-void SyncableFileOperationRunner::PostOperationTask(scoped_ptr<Task> task) {

+void SyncableFileOperationRunner::PostOperationTask(

+ std::unique_ptr<Task> task) {

DCHECK(CalledOnValidThread());

pending_tasks_.push_back(task.release());

RunNextRunnableTask();

@@ -81,7 +82,7 @@ void SyncableFileOperationRunner::RunNextRunnableTask() {

if ((*iter)->IsRunnable(sync_status())) {

++num_inflight_tasks_;

DCHECK_GE(num_inflight_tasks_, 1);

- scoped_ptr<Task> task(*iter);

+ std::unique_ptr<Task> task(*iter);

pending_tasks_.erase(iter++);

task->Start(sync_status());

continue;