chrome/browser/sync_file_system/local/local_file_sync_service.h - Issue 1873683002: Convert //chrome/browser/sync_file_system from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/local/local_file_sync_service.h

Issue 1873683002: Convert //chrome/browser/sync_file_system from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc ('k') | chrome/browser/sync_file_system/local/local_file_sync_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/local/local_file_sync_service.h

diff --git a/chrome/browser/sync_file_system/local/local_file_sync_service.h b/chrome/browser/sync_file_system/local/local_file_sync_service.h

index 3fe17e8da106d1d0daefc578bd09e8b74998ce39..66efac089191d12e3dcf2dfbf734aaf3a9447e06 100644

--- a/chrome/browser/sync_file_system/local/local_file_sync_service.h

+++ b/chrome/browser/sync_file_system/local/local_file_sync_service.h

@@ -8,13 +8,13 @@

#include <stdint.h>

#include <map>

+#include <memory>

#include <set>

#include <string>

#include "base/callback.h"

#include "base/macros.h"

#include "base/memory/ref_counted.h"

-#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "base/observer_list.h"

#include "chrome/browser/sync_file_system/local/local_origin_change_observer.h"

@@ -73,8 +73,8 @@ class LocalFileSyncService

bool has_pending_changes)>

HasPendingLocalChangeCallback;

- static scoped_ptr<LocalFileSyncService> Create(Profile* profile);

- static scoped_ptr<LocalFileSyncService> CreateForTesting(

+ static std::unique_ptr<LocalFileSyncService> Create(Profile* profile);

+ static std::unique_ptr<LocalFileSyncService> CreateForTesting(

Profile* profile,

leveldb::Env* env_override);

~LocalFileSyncService() override;