chrome/browser/sync_file_system/drive_backend/sync_task.h - Issue 1873683002: Convert //chrome/browser/sync_file_system from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/sync_task.h

Issue 1873683002: Convert //chrome/browser/sync_file_system from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc ('k') | chrome/browser/sync_file_system/drive_backend/sync_task.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/sync_task.h

diff --git a/chrome/browser/sync_file_system/drive_backend/sync_task.h b/chrome/browser/sync_file_system/drive_backend/sync_task.h

index 670c2141215f5d03500da663a0bd192007b5b9bd..a5e1f423de01b069b761644a90ded82f69eaad01 100644

--- a/chrome/browser/sync_file_system/drive_backend/sync_task.h

+++ b/chrome/browser/sync_file_system/drive_backend/sync_task.h

@@ -5,8 +5,9 @@

#ifndef CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_BACKEND_SYNC_TASK_H_

#define CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_BACKEND_SYNC_TASK_H_

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "chrome/browser/sync_file_system/sync_callbacks.h"

@@ -19,7 +20,7 @@ class SyncTask {

public:

SyncTask() : used_network_(false) {}

virtual ~SyncTask() {}

- virtual void RunPreflight(scoped_ptr<SyncTaskToken> token) = 0;

+ virtual void RunPreflight(std::unique_ptr<SyncTaskToken> token) = 0;

bool used_network() { return used_network_; }

@@ -39,7 +40,7 @@ class ExclusiveTask : public SyncTask {

ExclusiveTask();

~ExclusiveTask() override;

- void RunPreflight(scoped_ptr<SyncTaskToken> token) final;

+ void RunPreflight(std::unique_ptr<SyncTaskToken> token) final;

virtual void RunExclusive(const SyncStatusCallback& callback) = 0;

private: