chrome/browser/sync_file_system/drive_backend/drive_backend_util.h - Issue 1873683002: Convert //chrome/browser/sync_file_system from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/drive_backend_util.h

Issue 1873683002: Convert //chrome/browser/sync_file_system from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.cc ('k') | chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/drive_backend_util.h

diff --git a/chrome/browser/sync_file_system/drive_backend/drive_backend_util.h b/chrome/browser/sync_file_system/drive_backend/drive_backend_util.h

index d393776b464a430f345f07203c0219a3dba9171c..8231164161ac01cd8bb45bd50f636bd279a646fc 100644

--- a/chrome/browser/sync_file_system/drive_backend/drive_backend_util.h

+++ b/chrome/browser/sync_file_system/drive_backend/drive_backend_util.h

@@ -7,11 +7,11 @@

#include <stdint.h>

+#include <memory>

#include <string>

#include "base/bind.h"

#include "base/callback.h"

-#include "base/memory/scoped_ptr.h"

#include "chrome/browser/sync_file_system/drive_backend/metadata_database.pb.h"

#include "chrome/browser/sync_file_system/sync_status_code.h"

#include "google_apis/drive/drive_api_error_codes.h"

@@ -52,7 +52,7 @@ SyncStatusCode DriveApiErrorCodeToSyncStatusCode(

bool RemovePrefix(const std::string& str, const std::string& prefix,

std::string* out);

-scoped_ptr<ServiceMetadata> InitializeServiceMetadata(LevelDBWrapper* db);

+std::unique_ptr<ServiceMetadata> InitializeServiceMetadata(LevelDBWrapper* db);

template <typename Src, typename Dest>

void AppendContents(const Src& src, Dest* dest) {