chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc - Issue 1873683002: Convert //chrome/browser/sync_file_system from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc

Issue 1873683002: Convert //chrome/browser/sync_file_system from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/callback_helper.h ('k') | chrome/browser/sync_file_system/drive_backend/callback_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc b/chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc

index 6a5cfaae7706a3162ea2f8feb3e271c1fbbde3c7..9fb96c6325cb024f9ec46cae8dfba4657a6ad878 100644

--- a/chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc

+++ b/chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc

@@ -22,7 +22,7 @@ void SimpleCallback(bool* called, int) {

*called = true;

}

-void CallbackWithPassed(bool* called, scoped_ptr<int>) {

+void CallbackWithPassed(bool* called, std::unique_ptr<int>) {

ASSERT_TRUE(called);

EXPECT_FALSE(*called);

*called = true;

@@ -52,10 +52,9 @@ TEST(DriveBackendCallbackHelperTest, BasicTest) {

EXPECT_TRUE(called);

called = false;

- RelayCallbackToCurrentThread(

- FROM_HERE,

- base::Bind(&CallbackWithPassed, &called))

- .Run(scoped_ptr<int>(new int));

+ RelayCallbackToCurrentThread(FROM_HERE,

+ base::Bind(&CallbackWithPassed, &called))

+ .Run(std::unique_ptr<int>(new int));

EXPECT_FALSE(called);

base::RunLoop().RunUntilIdle();

EXPECT_TRUE(called);