Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1873683002: Convert //chrome/browser/sync_file_system from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //chrome/browser/sync_file_system from scoped_ptr to std::unique_ptr BUG=554298 Committed: https://crrev.com/566c3c55ebc5fa4600c3e6259938c3f9e1baf483 Cr-Commit-Position: refs/heads/master@{#386092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1142 lines, -1187 lines) Patch
M chrome/browser/sync_file_system/drive_backend/callback_helper.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/callback_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/callback_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/callback_tracker_internal.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/callback_tracker_internal.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/conflict_resolver.h View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc View 10 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc View 7 chunks +17 lines, -19 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.h View 2 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc View 13 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_sync_worker.h View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_sync_worker.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/folder_creator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/folder_creator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task.h View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task_unittest.cc View 8 chunks +21 lines, -20 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.h View 5 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc View 19 chunks +34 lines, -29 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc View 5 chunks +17 lines, -19 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.h View 6 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 39 chunks +67 lines, -73 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.h View 4 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc View 7 chunks +20 lines, -18 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc View 23 chunks +31 lines, -30 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc View 16 chunks +46 lines, -56 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc View 4 chunks +22 lines, -24 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 16 chunks +24 lines, -21 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_db_migration_util.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_db_migration_util_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc View 11 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.h View 7 chunks +35 lines, -33 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc View 25 chunks +37 lines, -35 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc View 5 chunks +16 lines, -20 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.h View 7 chunks +21 lines, -19 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 11 chunks +31 lines, -42 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_context.h View 3 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_context.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h View 3 chunks +21 lines, -22 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc View 13 chunks +21 lines, -18 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc View 14 chunks +36 lines, -36 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager.h View 8 chunks +30 lines, -25 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc View 12 chunks +25 lines, -26 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc View 14 chunks +45 lines, -77 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_token.h View 5 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_token.cc View 5 chunks +25 lines, -27 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.h View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.cc View 14 chunks +24 lines, -33 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker_interface.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker_unittest.cc View 4 chunks +19 lines, -24 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/task_dependency_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/uninstall_app_task.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/canned_syncable_file_system.h View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/canned_syncable_file_system.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker.cc View 7 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context.h View 7 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context.cc View 10 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/sync_file_system_backend.h View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/local/sync_file_system_backend.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_operation_runner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_operation_runner.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_operation.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_operation.cc View 10 chunks +21 lines, -30 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/mock_remote_file_sync_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/remote_file_sync_service.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/remote_file_sync_service.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.h View 4 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 6 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_factory.h View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_factory.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_test_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/sync_process_runner.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/sync_process_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/sync_process_runner_unittest.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/task_logger.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/task_logger.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
This is largely a search and replace. There's probably some IWYU errors (files that don't ...
4 years, 8 months ago (2016-04-08 05:07:22 UTC) #2
tzik
lgtm
4 years, 8 months ago (2016-04-08 13:05:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873683002/1
4 years, 8 months ago (2016-04-08 15:41:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 16:07:43 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 16:10:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/566c3c55ebc5fa4600c3e6259938c3f9e1baf483
Cr-Commit-Position: refs/heads/master@{#386092}

Powered by Google App Engine
This is Rietveld 408576698