Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: net/quic/quic_session.cc

Issue 1873673002: relnote: Deprecate --quic_auto_tune_receive_window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_CL_118974770
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_session.h ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_session.cc
diff --git a/net/quic/quic_session.cc b/net/quic/quic_session.cc
index de558968e98c147f1576502c0f9d436af71646a8..e41f3a29d637b9dd3b16251ce7ec36fbdd025347 100644
--- a/net/quic/quic_session.cc
+++ b/net/quic/quic_session.cc
@@ -45,7 +45,7 @@ QuicSession::QuicSession(QuicConnection* connection, const QuicConfig& config)
perspective(),
kMinimumFlowControlSendWindow,
config_.GetInitialSessionFlowControlWindowToSend(),
- false),
+ perspective() == Perspective::IS_SERVER),
currently_writing_stream_id_(0) {}
void QuicSession::Initialize() {
@@ -375,24 +375,6 @@ void QuicSession::OnConfigNegotiated() {
connection_->SetFromConfig(config_);
uint32_t max_streams = config_.MaxStreamsPerConnection();
- if (perspective() == Perspective::IS_SERVER) {
- if (config_.HasReceivedConnectionOptions()) {
- if (ContainsQuicTag(config_.ReceivedConnectionOptions(), kAFCW)) {
- // The following variations change the initial receive flow control
- // window sizes.
- if (ContainsQuicTag(config_.ReceivedConnectionOptions(), kIFW5)) {
- AdjustInitialFlowControlWindows(32 * 1024);
- }
- if (ContainsQuicTag(config_.ReceivedConnectionOptions(), kIFW6)) {
- AdjustInitialFlowControlWindows(64 * 1024);
- }
- if (ContainsQuicTag(config_.ReceivedConnectionOptions(), kIFW7)) {
- AdjustInitialFlowControlWindows(128 * 1024);
- }
- EnableAutoTuneReceiveWindow();
- }
- }
- }
set_max_open_outgoing_streams(max_streams);
@@ -418,45 +400,6 @@ void QuicSession::OnConfigNegotiated() {
}
}
-void QuicSession::EnableAutoTuneReceiveWindow() {
- DVLOG(1) << ENDPOINT << "Enable auto tune receive windows";
- flow_controller_.set_auto_tune_receive_window(true);
- // Inform all existing streams about the new window.
- for (auto const& kv : static_stream_map_) {
- kv.second->flow_controller()->set_auto_tune_receive_window(true);
- }
- for (auto const& kv : dynamic_stream_map_) {
- kv.second->flow_controller()->set_auto_tune_receive_window(true);
- }
-}
-
-void QuicSession::AdjustInitialFlowControlWindows(size_t stream_window) {
- const float session_window_multiplier =
- config_.GetInitialStreamFlowControlWindowToSend()
- ? static_cast<float>(
- config_.GetInitialSessionFlowControlWindowToSend()) /
- config_.GetInitialStreamFlowControlWindowToSend()
- : 1.0;
- DVLOG(1) << ENDPOINT << "Set stream receive window to " << stream_window;
- config_.SetInitialStreamFlowControlWindowToSend(stream_window);
- // Reduce the session window as well, motivation is reducing resource waste
- // and denial of service vulnerability, as with the stream window. Session
- // size is set according to the ratio between session and stream window size
- // previous to auto-tuning. Note that the ratio may change dynamically, since
- // auto-tuning acts independently for each flow controller.
- size_t session_window = session_window_multiplier * stream_window;
- DVLOG(1) << ENDPOINT << "Set session receive window to " << session_window;
- config_.SetInitialSessionFlowControlWindowToSend(session_window);
- flow_controller_.UpdateReceiveWindowSize(session_window);
- // Inform all existing streams about the new window.
- for (auto const& kv : static_stream_map_) {
- kv.second->flow_controller()->UpdateReceiveWindowSize(stream_window);
- }
- for (auto const& kv : dynamic_stream_map_) {
- kv.second->flow_controller()->UpdateReceiveWindowSize(stream_window);
- }
-}
-
void QuicSession::HandleFrameOnNonexistentOutgoingStream(
QuicStreamId stream_id) {
DCHECK(!IsClosedStream(stream_id));
« no previous file with comments | « net/quic/quic_session.h ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698