Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: net/quic/quic_flow_controller_test.cc

Issue 1873673002: relnote: Deprecate --quic_auto_tune_receive_window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_CL_118974770
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_flow_controller.cc ('k') | net/quic/quic_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_flow_controller_test.cc
diff --git a/net/quic/quic_flow_controller_test.cc b/net/quic/quic_flow_controller_test.cc
index 96b157dd525e63eec3887a538ea15ab0e653d084..dbe747756c98dfd7479b2bb90c25754037c724fa 100644
--- a/net/quic/quic_flow_controller_test.cc
+++ b/net/quic/quic_flow_controller_test.cc
@@ -153,7 +153,6 @@ TEST_F(QuicFlowControllerTest, OnlySendBlockedFrameOncePerOffset) {
}
TEST_F(QuicFlowControllerTest, ReceivingBytesFastIncreasesFlowWindow) {
- ValueRestore<bool> old_flag(&FLAGS_quic_auto_tune_receive_window, true);
// This test will generate two WINDOW_UPDATE frames.
EXPECT_CALL(connection_, SendWindowUpdate(stream_id_, ::testing::_)).Times(2);
@@ -206,118 +205,7 @@ TEST_F(QuicFlowControllerTest, ReceivingBytesFastIncreasesFlowWindow) {
EXPECT_GT(new_threshold, threshold);
}
-TEST_F(QuicFlowControllerTest, ReceivingBytesFastStatusQuo) {
- ValueRestore<bool> old_flag(&FLAGS_quic_auto_tune_receive_window, false);
- // This test will generate two WINDOW_UPDATE frames.
- EXPECT_CALL(connection_, SendWindowUpdate(stream_id_, ::testing::_)).Times(2);
-
- Initialize();
- flow_controller_->set_auto_tune_receive_window(true);
-
- // Make sure clock is inititialized.
- connection_.AdvanceTime(QuicTime::Delta::FromMilliseconds(1));
-
- QuicSentPacketManager* manager =
- QuicConnectionPeer::GetSentPacketManager(&connection_);
-
- RttStats* rtt_stats = QuicSentPacketManagerPeer::GetRttStats(manager);
- rtt_stats->UpdateRtt(QuicTime::Delta::FromMilliseconds(kRtt),
- QuicTime::Delta::Zero(), QuicTime::Zero());
-
- EXPECT_FALSE(flow_controller_->IsBlocked());
- EXPECT_FALSE(flow_controller_->FlowControlViolation());
- EXPECT_EQ(kInitialSessionFlowControlWindowForTest,
- QuicFlowControllerPeer::ReceiveWindowSize(flow_controller_.get()));
-
- QuicByteCount threshold =
- QuicFlowControllerPeer::WindowUpdateThreshold(flow_controller_.get());
-
- QuicStreamOffset receive_offset = threshold + 1;
- // Receive some bytes, updating highest received offset, but not enough to
- // fill flow control receive window.
- EXPECT_TRUE(flow_controller_->UpdateHighestReceivedOffset(receive_offset));
- EXPECT_FALSE(flow_controller_->FlowControlViolation());
- EXPECT_EQ(kInitialSessionFlowControlWindowForTest - receive_offset,
- QuicFlowControllerPeer::ReceiveWindowSize(flow_controller_.get()));
-
- // Consume enough bytes to send a WINDOW_UPDATE frame.
- flow_controller_->AddBytesConsumed(threshold + 1);
- // Result is that once again we have a fully open receive window.
- EXPECT_FALSE(flow_controller_->FlowControlViolation());
- EXPECT_EQ(kInitialSessionFlowControlWindowForTest,
- QuicFlowControllerPeer::ReceiveWindowSize(flow_controller_.get()));
-
- // Move time forward, but by less than two RTTs. Then receive and consume
- // some more, forcing a second WINDOW_UPDATE with an increased max window
- // size.
- connection_.AdvanceTime(QuicTime::Delta::FromMilliseconds(2 * kRtt - 1));
- receive_offset += threshold + 1;
- EXPECT_TRUE(flow_controller_->UpdateHighestReceivedOffset(receive_offset));
- flow_controller_->AddBytesConsumed(threshold + 1);
- EXPECT_FALSE(flow_controller_->FlowControlViolation());
- QuicByteCount new_threshold =
- QuicFlowControllerPeer::WindowUpdateThreshold(flow_controller_.get());
- EXPECT_EQ(new_threshold, threshold);
-}
-
TEST_F(QuicFlowControllerTest, ReceivingBytesNormalStableFlowWindow) {
- ValueRestore<bool> old_flag(&FLAGS_quic_auto_tune_receive_window, true);
- // This test will generate two WINDOW_UPDATE frames.
- EXPECT_CALL(connection_, SendWindowUpdate(stream_id_, ::testing::_)).Times(2);
-
- Initialize();
- flow_controller_->set_auto_tune_receive_window(true);
-
- // Make sure clock is inititialized.
- connection_.AdvanceTime(QuicTime::Delta::FromMilliseconds(1));
-
- QuicSentPacketManager* manager =
- QuicConnectionPeer::GetSentPacketManager(&connection_);
- RttStats* rtt_stats = QuicSentPacketManagerPeer::GetRttStats(manager);
- rtt_stats->UpdateRtt(QuicTime::Delta::FromMilliseconds(kRtt),
- QuicTime::Delta::Zero(), QuicTime::Zero());
-
- EXPECT_FALSE(flow_controller_->IsBlocked());
- EXPECT_FALSE(flow_controller_->FlowControlViolation());
- EXPECT_EQ(kInitialSessionFlowControlWindowForTest,
- QuicFlowControllerPeer::ReceiveWindowSize(flow_controller_.get()));
-
- QuicByteCount threshold =
- QuicFlowControllerPeer::WindowUpdateThreshold(flow_controller_.get());
-
- QuicStreamOffset receive_offset = threshold + 1;
- // Receive some bytes, updating highest received offset, but not enough to
- // fill flow control receive window.
- EXPECT_TRUE(flow_controller_->UpdateHighestReceivedOffset(receive_offset));
- EXPECT_FALSE(flow_controller_->FlowControlViolation());
- EXPECT_EQ(kInitialSessionFlowControlWindowForTest - receive_offset,
- QuicFlowControllerPeer::ReceiveWindowSize(flow_controller_.get()));
-
- flow_controller_->AddBytesConsumed(threshold + 1);
-
- // Result is that once again we have a fully open receive window.
- EXPECT_FALSE(flow_controller_->FlowControlViolation());
- EXPECT_EQ(kInitialSessionFlowControlWindowForTest,
- QuicFlowControllerPeer::ReceiveWindowSize(flow_controller_.get()));
-
- // Move time forward, but by more than two RTTs. Then receive and consume
- // some more, forcing a second WINDOW_UPDATE with unchanged max window size.
- connection_.AdvanceTime(QuicTime::Delta::FromMilliseconds(2 * kRtt + 1));
-
- receive_offset += threshold + 1;
- EXPECT_TRUE(flow_controller_->UpdateHighestReceivedOffset(receive_offset));
-
- flow_controller_->AddBytesConsumed(threshold + 1);
- EXPECT_FALSE(flow_controller_->FlowControlViolation());
-
- QuicByteCount new_threshold =
- QuicFlowControllerPeer::WindowUpdateThreshold(flow_controller_.get());
-
- EXPECT_EQ(new_threshold, threshold);
-}
-
-TEST_F(QuicFlowControllerTest, ReceivingBytesNormalStatusQuo) {
- ValueRestore<bool> old_flag(&FLAGS_quic_auto_tune_receive_window, false);
// This test will generate two WINDOW_UPDATE frames.
EXPECT_CALL(connection_, SendWindowUpdate(stream_id_, ::testing::_)).Times(2);
« no previous file with comments | « net/quic/quic_flow_controller.cc ('k') | net/quic/quic_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698