Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1873543003: Add slides to VulkanViewer (Closed)

Created:
4 years, 8 months ago by jvanverth1
Modified:
4 years, 8 months ago
Reviewers:
egdaniel, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add slides to VulkanViewer Adds SKP loading, matching, and moving backwards as well as forwards GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1873543003 Committed: https://skia.googlesource.com/skia/+/2bb3b6d2bb2cb3cc72ba254b34fadde5319c141a

Patch Set 1 #

Patch Set 2 : Add slide support files #

Total comments: 2

Patch Set 3 : Reverse GM array; add name to Slide #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -20 lines) Patch
M src/gpu/vk/GrVkGpu.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
A tools/vulkan/viewer/GMSlide.h View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A tools/vulkan/viewer/GMSlide.cpp View 1 1 chunk +28 lines, -0 lines 0 comments Download
A tools/vulkan/viewer/SKPSlide.h View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A tools/vulkan/viewer/SKPSlide.cpp View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A tools/vulkan/viewer/Slide.h View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M tools/vulkan/viewer/VulkanViewer.h View 3 chunks +5 lines, -1 line 0 comments Download
M tools/vulkan/viewer/VulkanViewer.cpp View 1 2 3 chunks +132 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jvanverth1
4 years, 8 months ago (2016-04-07 20:36:21 UTC) #3
egdaniel
lgtm with one comment https://codereview.chromium.org/1873543003/diff/20001/tools/vulkan/viewer/GMSlide.h File tools/vulkan/viewer/GMSlide.h (right): https://codereview.chromium.org/1873543003/diff/20001/tools/vulkan/viewer/GMSlide.h#newcode24 tools/vulkan/viewer/GMSlide.h:24: SkString fName; should fName be ...
4 years, 8 months ago (2016-04-07 20:46:37 UTC) #4
jvanverth1
https://codereview.chromium.org/1873543003/diff/20001/tools/vulkan/viewer/GMSlide.h File tools/vulkan/viewer/GMSlide.h (right): https://codereview.chromium.org/1873543003/diff/20001/tools/vulkan/viewer/GMSlide.h#newcode24 tools/vulkan/viewer/GMSlide.h:24: SkString fName; On 2016/04/07 20:46:37, egdaniel wrote: > should ...
4 years, 8 months ago (2016-04-08 14:08:40 UTC) #5
jvanverth1
4 years, 8 months ago (2016-04-08 14:08:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873543003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873543003/40001
4 years, 8 months ago (2016-04-08 14:08:56 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 14:24:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2bb3b6d2bb2cb3cc72ba254b34fadde5319c141a

Powered by Google App Engine
This is Rietveld 408576698