Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1873533002: [DevTools] Force context creation when runtime is enabled. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
kozy, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Force context creation when runtime is enabled. BUG=597820, 601144 Committed: https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0 Cr-Commit-Position: refs/heads/master@{#385960}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -22 lines) Patch
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download
M content/renderer/devtools/devtools_agent.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 5 chunks +43 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 2 chunks +14 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 3 chunks +12 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 1 chunk +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dgozman
Take a look please.
4 years, 8 months ago (2016-04-07 20:18:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873533002/20001
4 years, 8 months ago (2016-04-07 20:18:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-07 21:55:06 UTC) #6
pfeldman
lgtm
4 years, 8 months ago (2016-04-08 00:10:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873533002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873533002/40001
4 years, 8 months ago (2016-04-08 00:33:33 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-08 03:05:30 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 03:08:50 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0
Cr-Commit-Position: refs/heads/master@{#385960}

Powered by Google App Engine
This is Rietveld 408576698