src/hydrogen-instructions.cc - Issue 187353005: Use Representation::Integer32() for smi types on 32-bit-tagged systems.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.cc

Issue 187353005: Use Representation::Integer32() for smi types on 32-bit-tagged systems. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed nit Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen-instructions.cc

diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc

index 05e88c7c358cf950e4e28756e38f0e7f46b793ec..2a2c43a105e0a228bfc351957e31e4825e36bb5d 100644

--- a/src/hydrogen-instructions.cc

+++ b/src/hydrogen-instructions.cc

@@ -2605,8 +2605,8 @@ HConstant::HConstant(ExternalReference reference)

void HConstant::Initialize(Representation r) {

if (r.IsNone()) {

- if (has_smi_value_ && SmiValuesAre31Bits()) {

- r = Representation::Smi();

+ if (has_smi_value_) {

+ r = Representation::FromType(Type::Smi());

} else if (has_int32_value_) {

r = Representation::Integer32();

} else if (has_double_value_) {

« no previous file with comments | « src/hydrogen.cc ('k') | src/types.cc » ('j') | no next file with comments »