Issue 187353005: Use Representation::Integer32() for smi types on 32-bit-tagged systems.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187353005: Use Representation::Integer32() for smi types on 32-bit-tagged systems. (Closed)

Created:
6 years, 9 months ago by Toon Verwaest

Modified:
6 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use Representation::Integer32() for smi types on 32-bit-tagged systems. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19684

Patch Set 2 : Addressed nit #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -12 lines)			Patch
M	src/hydrogen.cc	View		2 chunks	+3 lines, -9 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/types.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-crbug-349079.js	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

lgtm https://codereview.chromium.org/187353005/diff/1/src/types.cc File src/types.cc (right): https://codereview.chromium.org/187353005/diff/1/src/types.cc#newcode572 src/types.cc:572: ? Representation::Smi() : Representation::Integer32(); nit: 4 space indent

6 years, 9 months ago (2014-03-05 17:36:31 UTC) #2

Toon Verwaest

6 years, 9 months ago (2014-03-06 09:49:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19684 (tree was closed).

Expand Messages | Collapse Messages

Issue 187353005: Use Representation::Integer32() for smi types on 32-bit-tagged systems. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed nit #

Messages