Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1873493003: Added needed call to close() in _HexDigest. (Closed)

Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, David Yen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added needed call to close() in _HexDigest. BUG=561763 TBR=dpranke@chromium.org Committed: https://crrev.com/91e5254fa5611aedf5cb9c540a85aef0a19b92e3 Cr-Commit-Position: refs/heads/master@{#385910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/win/copy_cdb_to_output.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ken Russell (switch to Gerrit)
FYI, CQ'ing TBR'd. Tiny fix, tested locally.
4 years, 8 months ago (2016-04-07 21:52:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873493003/1
4 years, 8 months ago (2016-04-07 21:53:19 UTC) #3
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-07 21:57:16 UTC) #4
scottmg
(CPython has to close the file at the end of the function scope anyway.)
4 years, 8 months ago (2016-04-07 22:16:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 22:50:33 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 22:52:17 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/91e5254fa5611aedf5cb9c540a85aef0a19b92e3
Cr-Commit-Position: refs/heads/master@{#385910}

Powered by Google App Engine
This is Rietveld 408576698