Add SkFUZZF to help whitelist imagefilter fuzz failures

Add SkFUZZF to help whitelist imagefilter fuzz failures

The current use case for this is whitelisting MergeImageFilter failures when the number of inputs is too big. Presumably there will be other whitelisting use cases as we progress.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1873463002

Committed: https://skia.googlesource.com/skia/+/ff3681156ced7718a73eca1e170824866d9e5776

[robertphillips, 2016-04-07 15:57:34]

Description was changed from

==========
Add SkFUZZF to help whitelist imagefilter fuzz failures
==========

to

==========
Add SkFUZZF to help whitelist imagefilter fuzz failures
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-07 15:59:07]

Description was changed from

==========
Add SkFUZZF to help whitelist imagefilter fuzz failures
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add SkFUZZF to help whitelist imagefilter fuzz failures

The current use case for this is whitelisting MergeImageFilter failures when the
number of inputs is too big. Presumably there will be other whitelisting use
cases as we progress.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-07 15:59:07]

robertphillips@google.com changed reviewers:
+ reed@google.com

[kjlubick, 2016-04-07 16:47:09]

kjlubick@google.com changed reviewers:
+ kjlubick@google.com

[kjlubick, 2016-04-07 16:47:09]

https://codereview.chromium.org/1873463002/diff/1/include/core/SkTypes.h
File include/core/SkTypes.h (right):

https://codereview.chromium.org/1873463002/diff/1/include/core/SkTypes.h#newc...
include/core/SkTypes.h:156: #define SkFUZZF(args) SkDebugf("SkFUZZ: "); SkDebugf
args
This makes it on two lines?

[reed1, 2016-04-07 16:48:22]

more context for this?

[kjlubick, 2016-04-07 16:55:41]

On 2016/04/07 at 16:48:22, reed wrote:
> more context for this?

The idea is to allow us to whitelist fuzzer results.  For example, the fuzzer
was able to cause hangs by creating filters with a bunch of stuff in it.  I hope
to compile the code with a special fuzz flag to expose this output and use it
for analysis/whitelisting.

[robertphillips, 2016-04-07 16:56:38]

Kevin has added an image filter fuzzer that has started turning up some bugs.
One of the first is when the fuzzer cranks up the number of inputs to the
MergeImageFilter. We would like to whitelist all these (since the initial ones
are timing out/running out of memory) but we need some way to know they are
instances of the "too many inputs" bug. The SkFUZZF entry point lets us add
outputs that will only be enabled in the fuzzer. It can then parse the output
and ignore known issues.

https://codereview.chromium.org/1873463002/diff/1/include/core/SkTypes.h
File include/core/SkTypes.h (right):

https://codereview.chromium.org/1873463002/diff/1/include/core/SkTypes.h#newc...
include/core/SkTypes.h:156: #define SkFUZZF(args) SkDebugf("SkFUZZ: "); SkDebugf
args
On 2016/04/07 16:47:09, kjlubick wrote:
> This makes it on two lines?

Nope - no '\n' in the first SkDebugf

[robertphillips, 2016-04-07 18:36:55]

PTAL I have move the SkFUZZF macro to src

[robertphillips, 2016-04-08 17:19:52]

ping - Mike

[reed1, 2016-04-08 19:45:50]

lgtm w/ naming/comment nits

https://codereview.chromium.org/1873463002/diff/50001/src/core/SkFuzzLogging.h
File src/core/SkFuzzLogging.h (right):

https://codereview.chromium.org/1873463002/diff/50001/src/core/SkFuzzLogging....
src/core/SkFuzzLogging.h:13: #ifdef SK_FUZZ
nit: SK_FUZZ_LOGGING

https://codereview.chromium.org/1873463002/diff/50001/src/core/SkFuzzLogging....
src/core/SkFuzzLogging.h:13: #ifdef SK_FUZZ
// If you want to enable debugfs for image-filter-fuzzing (blah blah blah) ...
define this flag in your SkUserConfig.h or in your Make/Build system.

[robertphillips, 2016-04-08 20:30:09]

https://codereview.chromium.org/1873463002/diff/50001/src/core/SkFuzzLogging.h
File src/core/SkFuzzLogging.h (right):

https://codereview.chromium.org/1873463002/diff/50001/src/core/SkFuzzLogging....
src/core/SkFuzzLogging.h:13: #ifdef SK_FUZZ
On 2016/04/08 19:45:49, reed1 wrote:
> nit: SK_FUZZ_LOGGING

Done.

https://codereview.chromium.org/1873463002/diff/50001/src/core/SkFuzzLogging....
src/core/SkFuzzLogging.h:13: #ifdef SK_FUZZ
On 2016/04/08 19:45:49, reed1 wrote:
> // If you want to enable debugfs for image-filter-fuzzing (blah blah blah) ...
> define this flag in your SkUserConfig.h or in your Make/Build system.

Done.

[robertphillips, 2016-04-08 20:30:15]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 20:30:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1873463002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1873463002/70001

[commit-bot: I haz the power, 2016-04-08 20:40:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 20:40:41]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-08 21:02:06]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-04-08 21:02:07]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1873463002/#ps70001
(title: "Address code review issues")

[commit-bot: I haz the power, 2016-04-08 21:02:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1873463002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1873463002/70001

[commit-bot: I haz the power, 2016-04-08 21:03:08]

Description was changed from

==========
Add SkFUZZF to help whitelist imagefilter fuzz failures

The current use case for this is whitelisting MergeImageFilter failures when the
number of inputs is too big. Presumably there will be other whitelisting use
cases as we progress.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add SkFUZZF to help whitelist imagefilter fuzz failures

The current use case for this is whitelisting MergeImageFilter failures when the
number of inputs is too big. Presumably there will be other whitelisting use
cases as we progress.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/ff3681156ced7718a73eca1e170824866d9e5776
==========

[commit-bot: I haz the power, 2016-04-08 21:03:09]

Committed patchset #5 (id:70001) as
https://skia.googlesource.com/skia/+/ff3681156ced7718a73eca1e170824866d9e5776