Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1873453002: Some more improvements/fixes to the VulkanViewer (Closed)

Created:
4 years, 8 months ago by jvanverth1
Modified:
4 years, 8 months ago
Reviewers:
egdaniel, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Some more improvements/fixes to the VulkanViewer * display GM name in title bar * add ms timer for update loop * add ms/frame meter * fix vsync * add some notes for later GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1873453002 Committed: https://skia.googlesource.com/skia/+/3d6ed3ae75e45b36f92d7555893953f519c2a63d

Patch Set 1 #

Patch Set 2 : Remove unnecessary files #

Total comments: 6

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -19 lines) Patch
M gyp/vulkanviewer.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/vulkan/Application.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/vulkan/VulkanTestContext.cpp View 1 2 3 chunks +8 lines, -6 lines 0 comments Download
M tools/vulkan/Window.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tools/vulkan/Window.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tools/vulkan/viewer/VulkanViewer.h View 1 chunk +7 lines, -1 line 0 comments Download
M tools/vulkan/viewer/VulkanViewer.cpp View 1 2 4 chunks +62 lines, -6 lines 0 comments Download
M tools/vulkan/win/Window_win.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/vulkan/win/Window_win.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/vulkan/win/main_win.cpp View 4 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
jvanverth1
4 years, 8 months ago (2016-04-07 15:41:53 UTC) #4
egdaniel
lgtm with minor comments https://codereview.chromium.org/1873453002/diff/20001/tools/vulkan/VulkanTestContext.h File tools/vulkan/VulkanTestContext.h (right): https://codereview.chromium.org/1873453002/diff/20001/tools/vulkan/VulkanTestContext.h#newcode84 tools/vulkan/VulkanTestContext.h:84: sk_sp<SkSurface>* fSurfaces; // wrapped surface ...
4 years, 8 months ago (2016-04-07 17:03:16 UTC) #5
jvanverth1
https://codereview.chromium.org/1873453002/diff/20001/tools/vulkan/VulkanTestContext.h File tools/vulkan/VulkanTestContext.h (right): https://codereview.chromium.org/1873453002/diff/20001/tools/vulkan/VulkanTestContext.h#newcode84 tools/vulkan/VulkanTestContext.h:84: sk_sp<SkSurface>* fSurfaces; // wrapped surface for those images On ...
4 years, 8 months ago (2016-04-07 17:57:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873453002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873453002/40001
4 years, 8 months ago (2016-04-07 17:57:12 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 18:09:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3d6ed3ae75e45b36f92d7555893953f519c2a63d

Powered by Google App Engine
This is Rietveld 408576698