cc/debug/debug_colors.h - Issue 187343007: Adding fading effect for paint rectangles in HUD.

Side by Side Diff: cc/debug/debug_colors.h

Issue 187343007: Adding fading effect for paint rectangles in HUD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed int to unsigned. Removed const where it's needless. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | cc/debug/debug_colors.cc » ('j') | cc/debug/debug_colors.cc » ('J')

OLD	NEW
1 // Copyright 2012 The Chromium Authors. All rights reserved.	1 // Copyright 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_DEBUG_DEBUG_COLORS_H_	5 #ifndef CC_DEBUG_DEBUG_COLORS_H_

6 #define CC_DEBUG_DEBUG_COLORS_H_	6 #define CC_DEBUG_DEBUG_COLORS_H_

7	7

8 #include "base/basictypes.h"	8 #include "base/basictypes.h"

9 #include "third_party/skia/include/core/SkColor.h"	9 #include "third_party/skia/include/core/SkColor.h"

10	10

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62 static SkColor PictureTileBorderColor();	62 static SkColor PictureTileBorderColor();

63 static int PictureTileBorderWidth(const LayerTreeImpl* tree_impl);	63 static int PictureTileBorderWidth(const LayerTreeImpl* tree_impl);

64	64

65 static SkColor DirectPictureBorderColor();	65 static SkColor DirectPictureBorderColor();

66 static int DirectPictureBorderWidth(const LayerTreeImpl* tree_impl);	66 static int DirectPictureBorderWidth(const LayerTreeImpl* tree_impl);

67	67

68 static SkColor DefaultCheckerboardColor();	68 static SkColor DefaultCheckerboardColor();

69 static SkColor EvictedTileCheckerboardColor();	69 static SkColor EvictedTileCheckerboardColor();

70 static SkColor InvalidatedTileCheckerboardColor();	70 static SkColor InvalidatedTileCheckerboardColor();

71	71

72 static SkColor PaintRectBorderColor();	72 static const int kFadeSteps = 50;
	caseq 2014/03/06 12:40:04 why is this still signed? why is this still signed? danakj 2014/03/06 19:03:21 Chromium style guide says to use signed ints and D Show quoted text On 2014/03/06 12:40:04, caseq wrote: > why is this still signed? Chromium style guide says to use signed ints and DCHECKs rather than unsigned things except for stuff like size_t for array sizes.
	73 static SkColor PaintRectBorderColor(unsigned step);
	danakj 2014/03/06 19:03:21 so these should really be int, sorry. so these should really be int, sorry.
73 static int PaintRectBorderWidth();	74 static int PaintRectBorderWidth();

74 static SkColor PaintRectFillColor();	75 static SkColor PaintRectFillColor(unsigned step);

75	76

76 static SkColor PropertyChangedRectBorderColor();	77 static SkColor PropertyChangedRectBorderColor();

77 static int PropertyChangedRectBorderWidth();	78 static int PropertyChangedRectBorderWidth();

78 static SkColor PropertyChangedRectFillColor();	79 static SkColor PropertyChangedRectFillColor();

79	80

80 static SkColor SurfaceDamageRectBorderColor();	81 static SkColor SurfaceDamageRectBorderColor();

81 static int SurfaceDamageRectBorderWidth();	82 static int SurfaceDamageRectBorderWidth();

82 static SkColor SurfaceDamageRectFillColor();	83 static SkColor SurfaceDamageRectFillColor();

83	84

84 static SkColor ScreenSpaceLayerRectBorderColor();	85 static SkColor ScreenSpaceLayerRectBorderColor();

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
126 static SkColor MemoryDisplayTextColor();	127 static SkColor MemoryDisplayTextColor();

127 static SkColor PaintTimeDisplayTextAndGraphColor();	128 static SkColor PaintTimeDisplayTextAndGraphColor();

128	129

129 private:	130 private:

130 DISALLOW_IMPLICIT_CONSTRUCTORS(DebugColors);	131 DISALLOW_IMPLICIT_CONSTRUCTORS(DebugColors);

131 };	132 };

132	133

133 } // namespace cc	134 } // namespace cc

134	135

135 #endif // CC_DEBUG_DEBUG_COLORS_H_	136 #endif // CC_DEBUG_DEBUG_COLORS_H_

OLD	NEW