Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 187343004: Revert of re-land: Use browser compositor rendering stats in smoothness (Closed)

Created:
6 years, 9 months ago by Ilya Sherman
Modified:
6 years, 9 months ago
Reviewers:
nduca, ernstm, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Revert of re-land: Use browser compositor rendering stats in smoothness (https://codereview.chromium.org/174663008/) Reason for revert: Broke the smoothness perf tests on multiple bots. BUG=349338 Original issue's description: > re-land: Use browser compositor rendering stats in smoothness > > PERF SHERRIFS: This patch can change the metrics of smoothness up or down. > The new values should be more accurate than what we had before. If there are > large changes on a platform, we should still sanity check that everything works > as expected. > > Switch smoothness benchmark to use rendering stats from the top level > compositor; i.e. if data from a browser compositor is available, use that. > Otherwise use the data from the renderer compositor. > > The re-land fixes the problem where a browser compositor was present, but > didn't record rendering stats. That was the case with the reference > builds (that didn't have the patch that enabled recording) and on Android. > The new version checks if the browser compositor rendering stats events > actually have frames in them. If not, the render compositor stats will be used. > There is also a fix on the way to enable the recording on Android > (https://codereview.chromium.org/168193004/). > > R=tonyg@chromium.org,nduca@chromium.org > BUG=340753 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254811 TBR=nduca@chromium.org,tonyg@chromium.org,ernstm@chromium.org NOTREECHECKS=true NOTRY=true BUG=340753 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -73 lines) Patch
M tools/perf/metrics/rendering_stats.py View 7 chunks +3 lines, -26 lines 0 comments Download
M tools/perf/metrics/rendering_stats_unittest.py View 6 chunks +18 lines, -46 lines 0 comments Download
M tools/perf/metrics/smoothness.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ilya Sherman
Created Revert of re-land: Use browser compositor rendering stats in smoothness
6 years, 9 months ago (2014-03-05 07:02:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/187343004/1
6 years, 9 months ago (2014-03-05 07:03:57 UTC) #2
commit-bot: I haz the power
Change committed as 254969
6 years, 9 months ago (2014-03-05 07:06:59 UTC) #3
ernstm
6 years, 9 months ago (2014-03-05 18:22:53 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698