Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1873403004: Add tandrii@ to watcher of git_cl.py changes. (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tandrii@ to watcher of git_cl.py changes. Reason: so I can not lgtm/revert anything which doesn't come with more tests. R=iannucci@chromium.org,dpranke@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299921

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M WATCHLISTS View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
tandrii(chromium)
4 years, 8 months ago (2016-04-12 14:28:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873403004/1
4 years, 8 months ago (2016-04-12 14:28:33 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-12 14:31:11 UTC) #5
Dirk Pranke
https://codereview.chromium.org/1873403004/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/1873403004/diff/1/WATCHLISTS#newcode21 WATCHLISTS:21: 'git_cl.py': [ You need to add an entry to ...
4 years, 8 months ago (2016-04-12 15:21:18 UTC) #6
tandrii(chromium)
https://codereview.chromium.org/1873403004/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/1873403004/diff/1/WATCHLISTS#newcode21 WATCHLISTS:21: 'git_cl.py': [ On 2016/04/12 15:21:17, Dirk Pranke wrote: > ...
4 years, 8 months ago (2016-04-13 09:35:44 UTC) #7
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-14 00:47:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873403004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873403004/20001
4 years, 8 months ago (2016-04-14 09:01:32 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 09:04:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299921

Powered by Google App Engine
This is Rietveld 408576698