Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chrome/utility/importer/bookmark_html_reader.h

Issue 1873403003: Read bookmarks from 'NETSCAPE-Bookmark-file's that don't have a beginning <DT> tag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed failing tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/utility/importer/bookmark_html_reader.h
diff --git a/chrome/utility/importer/bookmark_html_reader.h b/chrome/utility/importer/bookmark_html_reader.h
index 8150347cefd0bc7cf6cccbce838ad8aae717c9f8..219fd772479b539f7d27a216964e1005c8919d10 100644
--- a/chrome/utility/importer/bookmark_html_reader.h
+++ b/chrome/utility/importer/bookmark_html_reader.h
@@ -72,7 +72,7 @@ namespace internal {
bool ParseCharsetFromLine(const std::string& line,
std::string* charset);
-bool ParseFolderNameFromLine(const std::string& line,
+bool ParseFolderNameFromLine(std::string line,
const std::string& charset,
base::string16* folder_name,
bool* is_toolbar_folder,
@@ -80,7 +80,7 @@ bool ParseFolderNameFromLine(const std::string& line,
// See above, this will also put the data: URL of the favicon into |*favicon|
// if there is a favicon given. |post_data| is set for POST base keywords to
// the contents of the actual POST (with %s for the search term).
-bool ParseBookmarkFromLine(const std::string& line,
+bool ParseBookmarkFromLine(std::string line,
const std::string& charset,
base::string16* title,
GURL* url,
@@ -96,7 +96,7 @@ bool ParseBookmarkFromLine(const std::string& line,
// <dt><a href="url">name</a></dt>
// <dt><a href="url">name</a></dt>
// </dl>
-bool ParseMinimumBookmarkFromLine(const std::string& line,
+bool ParseMinimumBookmarkFromLine(std::string line,
const std::string& charset,
base::string16* title,
GURL* url);

Powered by Google App Engine
This is Rietveld 408576698