Issue 18734003: Only depend on icudata on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18734003: Only depend on icudata on windows. (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Only depend on icudata on windows. On windows, this triggers the dll to be copied to the correct locations. On other platforms, icudata is compiled in, and depending on it results in an invalid linker archive ordering. BUG=v8:2745 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15619

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -3 lines)			Patch
M	samples/samples.gyp	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/d8.gyp	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+7 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

7 years, 5 months ago (2013-07-11 11:01:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15619 (presubmit successful).