Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 187333004: Fix direction of horizontal scroll when tilting the scroll wheel on Linux Aura (Closed)

Created:
6 years, 9 months ago by pkotwicz
Modified:
6 years, 9 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Visibility:
Public.

Description

Fix direction of horizontal scroll when tilting the scroll wheel on Linux Aura BUG=342926 TEST=Manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255142

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/events/x/events_x.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/x/events_x_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pkotwicz
Sadrul, can you please take a look? MouseWheelEvent::offset_ documents the correct sign. I guess this ...
6 years, 9 months ago (2014-03-05 02:58:36 UTC) #1
sadrul
lgtm
6 years, 9 months ago (2014-03-05 12:05:48 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 9 months ago (2014-03-05 15:13:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/187333004/1
6 years, 9 months ago (2014-03-05 15:13:20 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 21:01:37 UTC) #5
Message was sent while issue was closed.
Change committed as 255142

Powered by Google App Engine
This is Rietveld 408576698