third_party/WebKit/Source/bindings/scripts/v8_dictionary.py - Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_dictionary.py

Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_attributes.py ('k') | third_party/WebKit/Source/bindings/scripts/v8_interface.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_dictionary.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py b/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py

index a6abb3134d69318c575c83f729ecdaa42e0b8256..3db6a3b0a0f8c3a40736ba09c6b3a771de293e46 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py

@@ -125,7 +125,7 @@ def member_context(dictionary, member):

'enum_values': unwrapped_idl_type.enum_values,

'has_method_name': has_method_name_for_dictionary_member(member),

'idl_type': idl_type.base_type,

- 'is_interface_type': idl_type.is_interface_type and not (idl_type.is_dictionary_type or is_deprecated_dictionary),

+ 'is_interface_type': idl_type.is_interface_type and not is_deprecated_dictionary,

'is_nullable': idl_type.is_nullable,

'is_object': unwrapped_idl_type.name == 'Object' or is_deprecated_dictionary,

'is_required': member.is_required,