Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1873283002:
Blacklist CALayer overlays on 10.10 (Closed)
|
Created:
4 years, 8 months ago by ccameron Modified:
4 years, 7 months ago Reviewers:
Zhenyao Mo CC:
chromium-reviews, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBlacklist CALayer overlays on 10.10
This is causing hangs on 10.10. Forcing fallback to the GL renderer
makes the issue go away according to people who have seen the
issue.
So far all reports of this issue are on the following dual-GPU
combination:
iGPU: 0x8086, 0x0166
dGPU: 0x10de, 0x0fd5
If this improves histograms, we will try to limit the scope of
the blacklist to just this combination.
BUG=580616
Committed: https://crrev.com/d5c58b5bfba2721be8681f67e784279e2030c423
Cr-Commit-Position: refs/heads/master@{#386783}
Patch Set 1 #Patch Set 2 : Update version #Messages
Total messages: 20 (11 generated)
Description was changed from ========== Blacklist CALayer overlays on 10.10 BUG=580616 ========== to ========== Blacklist CALayer overlays on 10.10 BUG=580616 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Blacklist CALayer overlays on 10.10 BUG=580616 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Blacklist CALayer overlays on 10.10 This is causing hangs on 10.10. Forcing fallback to the GL renderer seems to make the issue go away. BUG=580616 ==========
ccameron@chromium.org changed reviewers: + zmo@chromium.org
On 2016/04/12 15:47:03, ccameron wrote: lgtm after you update the version
Description was changed from ========== Blacklist CALayer overlays on 10.10 This is causing hangs on 10.10. Forcing fallback to the GL renderer seems to make the issue go away. BUG=580616 ========== to ========== Blacklist CALayer overlays on 10.10 This is causing hangs on 10.10. Forcing fallback to the GL renderer seems to make the issue go away. BUG=580616 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Blacklist CALayer overlays on 10.10 This is causing hangs on 10.10. Forcing fallback to the GL renderer seems to make the issue go away. BUG=580616 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Blacklist CALayer overlays on 10.10 This is causing hangs on 10.10. Forcing fallback to the GL renderer makes the issue go away according to people who have seen the issue. So far all reports of this issue are on the following dual-GPU combination: iGPU: 0x8086, 0x0166 dGPU: 0x10de, 0x0fd5 If this improves histograms, we will try to limit the scope of the blacklist to just this combination. BUG=580616 ==========
Done.
The CQ bit was checked by ccameron@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org Link to the patchset: https://codereview.chromium.org/1873283002/#ps20001 (title: "Update version")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873283002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by ccameron@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873283002/20001
Message was sent while issue was closed.
Description was changed from ========== Blacklist CALayer overlays on 10.10 This is causing hangs on 10.10. Forcing fallback to the GL renderer makes the issue go away according to people who have seen the issue. So far all reports of this issue are on the following dual-GPU combination: iGPU: 0x8086, 0x0166 dGPU: 0x10de, 0x0fd5 If this improves histograms, we will try to limit the scope of the blacklist to just this combination. BUG=580616 ========== to ========== Blacklist CALayer overlays on 10.10 This is causing hangs on 10.10. Forcing fallback to the GL renderer makes the issue go away according to people who have seen the issue. So far all reports of this issue are on the following dual-GPU combination: iGPU: 0x8086, 0x0166 dGPU: 0x10de, 0x0fd5 If this improves histograms, we will try to limit the scope of the blacklist to just this combination. BUG=580616 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Blacklist CALayer overlays on 10.10 This is causing hangs on 10.10. Forcing fallback to the GL renderer makes the issue go away according to people who have seen the issue. So far all reports of this issue are on the following dual-GPU combination: iGPU: 0x8086, 0x0166 dGPU: 0x10de, 0x0fd5 If this improves histograms, we will try to limit the scope of the blacklist to just this combination. BUG=580616 ========== to ========== Blacklist CALayer overlays on 10.10 This is causing hangs on 10.10. Forcing fallback to the GL renderer makes the issue go away according to people who have seen the issue. So far all reports of this issue are on the following dual-GPU combination: iGPU: 0x8086, 0x0166 dGPU: 0x10de, 0x0fd5 If this improves histograms, we will try to limit the scope of the blacklist to just this combination. BUG=580616 Committed: https://crrev.com/d5c58b5bfba2721be8681f67e784279e2030c423 Cr-Commit-Position: refs/heads/master@{#386783} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d5c58b5bfba2721be8681f67e784279e2030c423 Cr-Commit-Position: refs/heads/master@{#386783}
Message was sent while issue was closed.
Since this turned out to not be the issue, can we revert this? |
