components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc - Issue 1873263002: Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc

Issue 1873263002: Convert //components/data_reduction_proxy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/common/data_reduction_proxy_event_storage_delegate_test_utils.cc ('K') | « components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc ('k') | components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc » ('j') | components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc

diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc b/components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc

index fdcc54589d092080c74b45d7922cc9c0971af0f8..e3bea87e2953e96b8446bf88a357401f109cf3c3 100644

--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc

+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc

@@ -33,8 +33,8 @@ class DataReductionProxyHeadersTest : public testing::Test {

}

private:

- scoped_ptr<DataReductionProxyEventCreator> event_creator_;

- scoped_ptr<TestDataReductionProxyEventStorageDelegate> storage_delegate_;

+ std::unique_ptr<DataReductionProxyEventCreator> event_creator_;

+ std::unique_ptr<TestDataReductionProxyEventStorageDelegate> storage_delegate_;

megjablon 2016/04/12 21:55:36 #include <memory> ?

dcheng 2016/04/12 22:38:34 Done.

};

TEST_F(DataReductionProxyHeadersTest, GetDataReductionProxyActionValue) {