Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 187323007: Avoid a CHECK in ExtensionActionStorageManager::ReadFromStorage if an extension (Closed)

Created:
6 years, 9 months ago by Jeffrey Yasskin
Modified:
6 years, 9 months ago
Reviewers:
Yoyo Zhou, Matt Perry
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Avoid a CHECK in ExtensionActionStorageManager::ReadFromStorage if an extension has a browser action which it starts reading from storage on startup, but then it's updated to a new version with no browser action before the callback comes back. A better way to fix it would be to block the update until the extension is "started", but we need better infrastructure to do that. BUG=349371 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255201

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Jeffrey Yasskin
6 years, 9 months ago (2014-03-05 18:41:29 UTC) #1
Matt Perry
lgtm
6 years, 9 months ago (2014-03-05 19:07:30 UTC) #2
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 9 months ago (2014-03-05 19:07:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/187323007/1
6 years, 9 months ago (2014-03-05 19:08:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 20:35:13 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275544
6 years, 9 months ago (2014-03-05 20:35:14 UTC) #6
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 9 months ago (2014-03-05 21:16:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/187323007/1
6 years, 9 months ago (2014-03-05 21:20:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/187323007/1
6 years, 9 months ago (2014-03-06 00:01:56 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 01:20:24 UTC) #10
Message was sent while issue was closed.
Change committed as 255201

Powered by Google App Engine
This is Rietveld 408576698