Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 187323005: Revert of Remove support for legacy WebKit Notifications (Closed)

Created:
6 years, 9 months ago by Peter Beverloo
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Revert of Remove support for legacy WebKit Notifications (https://codereview.chromium.org/184733002/) Reason for revert: Broke interactive_ui_tests and browser_tests, as pointed out by cbiesinger. http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/35005 Original issue's description: > Remove support for legacy WebKit Notifications > > This patch removes support for the legacy WebKit notifications from Blink, > per the following Intent to Remove thread: > > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8vqyfHa8_dw > > BUG=348019 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168471 TBR=atwilson@chromium.org,jochen@chromium.org,abarth@chromium.org NOTREECHECKS=true NOTRY=true BUG=348019 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2094 lines, -200 lines) Patch
M LayoutTests/StaleTestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notification-after-close.html View 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notification-after-close-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notification-exceptions.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notification-exceptions-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-cancel-request-permission.html View 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-cancel-request-permission-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-check-permission.html View 1 chunk +48 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-check-permission-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-click-event.html View 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-click-event-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-click-event-focus.html View 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-click-event-focus-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-display-close-events.html View 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-display-close-events-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-document-close-crash.html View 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-document-close-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-event-stop-propagation.html-disabled View 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-event-stop-propagation-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-leak-document.html View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-leak-document-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-multi-events.html-disabled View 1 chunk +40 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-multi-events-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-no-icon.html View 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-no-icon-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-replace.html View 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-replace-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-rtl.html View 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-rtl-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-sandbox-permission.html View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-sandbox-permission-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-window-close-crash.html View 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-window-close-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-with-permission.html View 1 chunk +40 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-with-permission-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-without-permission.html View 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-without-permission-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/resources/notification-show.html View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/resources/notifications-cancel-request-permission.html View 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/resources/notifications-iframe.html View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/platform/android/fast/notifications/notifications-cancel-request-permission-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/events/EventTargetFactory.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/modules.gypi View 3 chunks +14 lines, -1 line 0 comments Download
A Source/modules/notifications/DOMWindowNotifications.h View 1 chunk +66 lines, -0 lines 0 comments Download
A Source/modules/notifications/DOMWindowNotifications.cpp View 1 chunk +107 lines, -0 lines 0 comments Download
M Source/modules/notifications/Notification.h View 4 chunks +9 lines, -70 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 7 chunks +8 lines, -104 lines 0 comments Download
A Source/modules/notifications/NotificationBase.h View 1 chunk +122 lines, -0 lines 0 comments Download
A Source/modules/notifications/NotificationBase.cpp View 1 chunk +154 lines, -0 lines 0 comments Download
A Source/modules/notifications/NotificationCenter.h View 1 chunk +113 lines, -0 lines 0 comments Download
A Source/modules/notifications/NotificationCenter.cpp View 1 chunk +144 lines, -0 lines 0 comments Download
A Source/modules/notifications/NotificationCenter.idl View 1 chunk +43 lines, -0 lines 0 comments Download
M Source/modules/notifications/NotificationClient.h View 2 chunks +7 lines, -4 lines 0 comments Download
A Source/modules/notifications/WebKitNotification.h View 1 chunk +78 lines, -0 lines 0 comments Download
A Source/modules/notifications/WebKitNotification.cpp View 1 chunk +83 lines, -0 lines 0 comments Download
A Source/modules/notifications/WebKitNotification.idl View 1 chunk +48 lines, -0 lines 0 comments Download
A Source/modules/notifications/WindowNotifications.idl View 1 chunk +33 lines, -0 lines 0 comments Download
A Source/modules/notifications/WorkerGlobalScopeNotifications.h View 1 chunk +62 lines, -0 lines 0 comments Download
A Source/modules/notifications/WorkerGlobalScopeNotifications.cpp View 1 chunk +77 lines, -0 lines 0 comments Download
A Source/modules/notifications/WorkerGlobalScopeNotifications.idl View 1 chunk +32 lines, -0 lines 0 comments Download
M Source/web/NotificationPresenterImpl.h View 1 chunk +6 lines, -3 lines 0 comments Download
M Source/web/NotificationPresenterImpl.cpp View 4 chunks +37 lines, -8 lines 0 comments Download
M Source/web/WebNotification.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M public/web/WebNotification.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Beverloo
Created Revert of Remove support for legacy WebKit Notifications
6 years, 9 months ago (2014-03-05 15:40:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/187323005/1
6 years, 9 months ago (2014-03-05 15:40:42 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 15:43:09 UTC) #3
Message was sent while issue was closed. 
Change committed as 168486

Powered by Google App Engine
This is Rietveld 408576698