Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(30)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/fast/dom/SelectorAPI/dumpNodeList-2-expected.txt
Issue
18732004
:
Add fast path for querySelector(All) (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set:
Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/fast/dom/SelectorAPI/dumpNodeList-2.html
LayoutTests/fast/dom/SelectorAPI/dumpNodeList-2-expected.txt
PerformanceTests/Parser/query-selector-all-class-deep.html
PerformanceTests/Parser/query-selector-all-class-first.html
PerformanceTests/Parser/query-selector-all-class-last.html
PerformanceTests/Parser/query-selector-all-deep.html
PerformanceTests/Parser/query-selector-all-first.html
PerformanceTests/Parser/query-selector-all-id-deep.html
PerformanceTests/Parser/query-selector-all-id-first.html
PerformanceTests/Parser/query-selector-all-id-last.html
PerformanceTests/Parser/query-selector-all-last.html
Source/core/dom/SelectorQuery.h
Source/core/dom/SelectorQuery.cpp
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« LayoutTests/fast/dom/SelectorAPI/dumpNodeList-2.html
('K') |
« LayoutTests/fast/dom/SelectorAPI/dumpNodeList-2.html
('k') |
PerformanceTests/Parser/query-selector-all-class-deep.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
line 4
2
line 5
3
4
PASS testQuerySelectorAll(document, ".target + div") is "[object HTMLDivElement] , [object HTMLDivElement], length: 2"
5
PASS testQuerySelectorAll(document.getElementById("test"), ".target + div") is " [object HTMLDivElement], [object HTMLDivElement], length: 2"
6
PASS testQuerySelectorAll(document.getElementById("test2"), ".target + div") is "length: 0"
7
PASS testQuerySelectorAll(document.getElementById("test3"), ".target + div") is "length: 0"
8
PASS successfullyParsed is true
9
10
TEST COMPLETE
11
OLD
NEW
« LayoutTests/fast/dom/SelectorAPI/dumpNodeList-2.html
('K') |
« LayoutTests/fast/dom/SelectorAPI/dumpNodeList-2.html
('k') |
PerformanceTests/Parser/query-selector-all-class-deep.html »
('j') |
no next file with comments »
Issue 18732004: Add fast path for querySelector(All) (Closed)
Created 7 years, 5 months ago by tasak
Modified 7 years, 4 months ago
Reviewers: haraken, esprehn
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 32
This is Rietveld
408576698