Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: trunk/src/build/android/pylib/gtest/dispatch.py

Issue 18732002: Revert 210035 "Creates a new test running script test_runner.py" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/build/android/pylib/gtest/dispatch.py
===================================================================
--- trunk/src/build/android/pylib/gtest/dispatch.py (revision 210250)
+++ trunk/src/build/android/pylib/gtest/dispatch.py (working copy)
@@ -2,8 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-"""Dispatches GTests."""
-
import copy
import fnmatch
import logging
@@ -67,8 +65,6 @@
Args:
runner: a TestRunner.
- Returns:
- All non-disabled tests on the device.
"""
# The executable/apk needs to be copied before we can call GetAllTests.
runner.test_package.StripAndCopyExecutable()
@@ -159,8 +155,8 @@
constants.GTEST_COMMAND_LINE_FILE)
# Get tests and split them up based on the number of devices.
- if options.test_filter:
- all_tests = [t for t in options.test_filter.split(':') if t]
+ if options.gtest_filter:
+ all_tests = [t for t in options.gtest_filter.split(':') if t]
else:
all_tests = GetAllEnabledTests(RunnerFactory, attached_devices)
num_devices = len(attached_devices)
@@ -214,7 +210,7 @@
framebuffer.Start()
all_test_suites = _FullyQualifiedTestSuites(options.exe, options.test_suite,
- options.build_type)
+ options.build_type)
failures = 0
for suite_name, suite_path in all_test_suites:
# Give each test suite its own copy of options.
« no previous file with comments | « trunk/src/build/android/pylib/browsertests/dispatch.py ('k') | trunk/src/build/android/pylib/gtest/test_package_apk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698