Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: trunk/src/build/android/adb_install_apk.py

Issue 18732002: Revert 210035 "Creates a new test running script test_runner.py" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/build/android/pylib/browsertests/dispatch.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/build/android/adb_install_apk.py
===================================================================
--- trunk/src/build/android/adb_install_apk.py (revision 210250)
+++ trunk/src/build/android/adb_install_apk.py (working copy)
@@ -4,8 +4,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-"""Utility script to install APKs from the command line quickly."""
-
import multiprocessing
import optparse
import os
@@ -17,32 +15,6 @@
from pylib.utils import test_options_parser
-def AddInstallAPKOption(option_parser):
- """Adds apk option used to install the APK to the OptionParser."""
- test_options_parser.AddBuildTypeOption(option_parser)
- option_parser.add_option('--apk',
- help=('The name of the apk containing the '
- ' application (with the .apk extension).'))
- option_parser.add_option('--apk_package',
- help=('The package name used by the apk containing '
- 'the application.'))
- option_parser.add_option('--keep_data',
- action='store_true',
- default=False,
- help=('Keep the package data when installing '
- 'the application.'))
-
-
-def ValidateInstallAPKOption(option_parser, options):
- """Validates the apk option and potentially qualifies the path."""
- if not options.apk:
- option_parser.error('--apk is mandatory.')
- if not os.path.exists(options.apk):
- options.apk = os.path.join(constants.DIR_SOURCE_ROOT,
- 'out', options.build_type,
- 'apks', options.apk)
-
-
def _InstallApk(args):
apk_path, apk_package, keep_data, device = args
result = android_commands.AndroidCommands(device=device).ManagedInstall(
@@ -53,9 +25,9 @@
def main(argv):
parser = optparse.OptionParser()
- AddInstallAPKOption(parser)
+ test_options_parser.AddInstallAPKOption(parser)
options, args = parser.parse_args(argv)
- ValidateInstallAPKOption(parser, options)
+ test_options_parser.ValidateInstallAPKOption(parser, options)
if len(args) > 1:
raise Exception('Error: Unknown argument:', args[1:])
« no previous file with comments | « no previous file | trunk/src/build/android/pylib/browsertests/dispatch.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698