[compiler] Set expect property count right after parsing.

[compiler] Set expect property count right after parsing.

This moves the computation of the {expected_nof_properties} for a shared
function to where the object is actually being allocated. This is done
after parsing when the literal has been populated already. The expected
number of properties is not mutated after parsing.

R=verwaest@chromium.org

Committed: https://crrev.com/8ce0a943e3aa77a80b63a75fc0308402404abeaa
Cr-Commit-Position: refs/heads/master@{#35391}

[Michael Starzinger, 2016-04-11 13:29:33]

Description was changed from

==========
[compiler] Set expect property count right after parsing.

This moves the computation of the {expected_nof_properties} for a shared
function to point where the object is actually being allocated. This is
done after parsing when the literal is populated. The expected number of
properties is not mutated after parsing.

R=
==========

to

==========
[compiler] Set expect property count right after parsing.

This moves the computation of the {expected_nof_properties} for a shared
function to point where the object is actually being allocated. This is
done after parsing when the literal is populated. The expected number of
properties is not mutated after parsing.

R=verwaest@chromium.org
==========

[Michael Starzinger, 2016-04-11 13:29:33]

mstarzinger@chromium.org changed reviewers:
+ verwaest@chromium.org

[Michael Starzinger, 2016-04-11 13:32:43]

https://codereview.chromium.org/1873173002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1873173002/diff/1/src/compiler.cc#newcode1018
src/compiler.cc:1018: SetExpectedNofPropertiesFromEstimate(result, literal);
This could even be moved out of "compiler.cc" entirely and places into
SharedFunctionInfo::InitFromFunctionLiteral instead. Please advise which is
preferred from a runtime point of view.

[Toon Verwaest, 2016-04-11 13:43:32]

lgtm, nice cleanup.

https://codereview.chromium.org/1873173002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1873173002/diff/1/src/compiler.cc#newcode1018
src/compiler.cc:1018: SetExpectedNofPropertiesFromEstimate(result, literal);
On 2016/04/11 13:32:42, Michael Starzinger wrote:
> This could even be moved out of "compiler.cc" entirely and places into
> SharedFunctionInfo::InitFromFunctionLiteral instead. Please advise which is
> preferred from a runtime point of view.

That sounds good. The helper function used to be in namespace { ... }, we
probably should keep it that way?

[Michael Starzinger, 2016-04-11 14:17:32]

Thanks! Comment addressed. Landing now-ish.

https://codereview.chromium.org/1873173002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1873173002/diff/1/src/compiler.cc#newcode1018
src/compiler.cc:1018: SetExpectedNofPropertiesFromEstimate(result, literal);
On 2016/04/11 13:43:32, Toon Verwaest wrote:
> On 2016/04/11 13:32:42, Michael Starzinger wrote:
> > This could even be moved out of "compiler.cc" entirely and places into
> > SharedFunctionInfo::InitFromFunctionLiteral instead. Please advise which is
> > preferred from a runtime point of view.
> 
> That sounds good. The helper function used to be in namespace { ... }, we
> probably should keep it that way?

Done.

[Michael Starzinger, 2016-04-11 14:26:26]

Description was changed from

==========
[compiler] Set expect property count right after parsing.

This moves the computation of the {expected_nof_properties} for a shared
function to point where the object is actually being allocated. This is
done after parsing when the literal is populated. The expected number of
properties is not mutated after parsing.

R=verwaest@chromium.org
==========

to

==========
[compiler] Set expect property count right after parsing.

This moves the computation of the {expected_nof_properties} for a shared
function to where the object is actually being allocated. This is done
after parsing when the literal has been populated already. The expected
number of properties is not mutated after parsing.

R=verwaest@chromium.org
==========

[Michael Starzinger, 2016-04-11 14:51:39]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-04-11 14:51:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1873173002/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-04-11 14:51:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1873173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1873173002/20001

[commit-bot: I haz the power, 2016-04-11 14:54:04]

Description was changed from

==========
[compiler] Set expect property count right after parsing.

This moves the computation of the {expected_nof_properties} for a shared
function to where the object is actually being allocated. This is done
after parsing when the literal has been populated already. The expected
number of properties is not mutated after parsing.

R=verwaest@chromium.org
==========

to

==========
[compiler] Set expect property count right after parsing.

This moves the computation of the {expected_nof_properties} for a shared
function to where the object is actually being allocated. This is done
after parsing when the literal has been populated already. The expected
number of properties is not mutated after parsing.

R=verwaest@chromium.org
==========

[commit-bot: I haz the power, 2016-04-11 14:54:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-11 14:54:40]

Description was changed from

==========
[compiler] Set expect property count right after parsing.

This moves the computation of the {expected_nof_properties} for a shared
function to where the object is actually being allocated. This is done
after parsing when the literal has been populated already. The expected
number of properties is not mutated after parsing.

R=verwaest@chromium.org
==========

to

==========
[compiler] Set expect property count right after parsing.

This moves the computation of the {expected_nof_properties} for a shared
function to where the object is actually being allocated. This is done
after parsing when the literal has been populated already. The expected
number of properties is not mutated after parsing.

R=verwaest@chromium.org

Committed: https://crrev.com/8ce0a943e3aa77a80b63a75fc0308402404abeaa
Cr-Commit-Position: refs/heads/master@{#35391}
==========

[commit-bot: I haz the power, 2016-04-11 14:54:42]

Patchset 2 (id:??) landed as
https://crrev.com/8ce0a943e3aa77a80b63a75fc0308402404abeaa
Cr-Commit-Position: refs/heads/master@{#35391}