[css-grid] Fix painting in RTL

[css-grid] Fix painting in RTL

Due to the optimization we've in GridPainter that only paints
the grid items in the cells affected by the paint invalidation rect,
we've an issue using direction RTL, as the cells to be painted
were wrongly detected.

The problem is that LayoutGrid::columnPositions() is not returning
physical positions in the case of RTL, so we need to translate that
vector before calling dirtiedGridAreas().
As we're changing the order of the tracks in the new translated Vector
we need to change the GridSpan we get as result from dirtiedGridAreas().

Created a helper function LayoutGrid::translateRTLCoordinate()
and used it in the different parts of the code where we need to do
this conversion.

TEST=fast/css-grid-layout/grid-painting-rtl.html

BUG=600680
Committed: https://crrev.com/53cea4d18b15b735c4ab6cd85cfcb3cc07593452
Cr-Commit-Position: refs/heads/master@{#387090}

[Manuel Rego, 2016-04-12 10:49:56]

Description was changed from

==========
[css-grid] Fix painting in RTL

Due to the optimization we've in GridPainter that only paints
the grid items in the cells affected by the paint invalidation rect,
we've an issue using direction RTL, as the cells to be painted
were wrongly detected.

The problem is that LayoutGrid::columnPositions() is not returning
physical positions in the case of RTL, so we need to translate that
vector before calling dirtiedGridAreas().

As we're changing the order of the tracks in the new translated Vector
we need to change the GridSpan we get as result from dirtiedGridAreas().

TEST=fast/css-grid-layout/grid-painting-rtl.html

BUG=600680
==========

to

==========
[css-grid] Fix painting in RTL

Due to the optimization we've in GridPainter that only paints
the grid items in the cells affected by the paint invalidation rect,
we've an issue using direction RTL, as the cells to be painted
were wrongly detected.

The problem is that LayoutGrid::columnPositions() is not returning
physical positions in the case of RTL, so we need to translate that
vector before calling dirtiedGridAreas().
As we're changing the order of the tracks in the new translated Vector
we need to change the GridSpan we get as result from dirtiedGridAreas().

Created a helper function LayoutGrid::translateRTLCoordinate()
and use it in the different parts of the code where we need to do
this conversion.

TEST=fast/css-grid-layout/grid-painting-rtl.html

BUG=600680
==========

[Manuel Rego, 2016-04-12 10:50:40]

Description was changed from

==========
[css-grid] Fix painting in RTL

Due to the optimization we've in GridPainter that only paints
the grid items in the cells affected by the paint invalidation rect,
we've an issue using direction RTL, as the cells to be painted
were wrongly detected.

The problem is that LayoutGrid::columnPositions() is not returning
physical positions in the case of RTL, so we need to translate that
vector before calling dirtiedGridAreas().
As we're changing the order of the tracks in the new translated Vector
we need to change the GridSpan we get as result from dirtiedGridAreas().

Created a helper function LayoutGrid::translateRTLCoordinate()
and use it in the different parts of the code where we need to do
this conversion.

TEST=fast/css-grid-layout/grid-painting-rtl.html

BUG=600680
==========

to

==========
[css-grid] Fix painting in RTL

Due to the optimization we've in GridPainter that only paints
the grid items in the cells affected by the paint invalidation rect,
we've an issue using direction RTL, as the cells to be painted
were wrongly detected.

The problem is that LayoutGrid::columnPositions() is not returning
physical positions in the case of RTL, so we need to translate that
vector before calling dirtiedGridAreas().
As we're changing the order of the tracks in the new translated Vector
we need to change the GridSpan we get as result from dirtiedGridAreas().

Created a helper function LayoutGrid::translateRTLCoordinate()
and used it in the different parts of the code where we need to do
this conversion.

TEST=fast/css-grid-layout/grid-painting-rtl.html

BUG=600680
==========

[Manuel Rego, 2016-04-12 10:52:55]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jfernandez@igalia.com, svillar@igalia.com

[Manuel Rego, 2016-04-12 10:52:56]

I know this is mostly a change in /paint
but it's 100% related to grid layout.

I'll add some reviewer to confirm the changes in /paint
once it's reviewed by the grid layout experts.

[cbiesinger, 2016-04-12 20:07:51]

https://codereview.chromium.org/1873163002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/GridPainter.cpp (right):

https://codereview.chromium.org/1873163002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/GridPainter.cpp:53: columnPositions[i] =
m_layoutGrid.translateRTLCoordinate(columnPositions[i]);
Why not make this translation inside of dirtiedGrisAreas?

[Manuel Rego, 2016-04-13 08:42:56]

https://codereview.chromium.org/1873163002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/GridPainter.cpp (right):

https://codereview.chromium.org/1873163002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/GridPainter.cpp:53: columnPositions[i] =
m_layoutGrid.translateRTLCoordinate(columnPositions[i]);
On 2016/04/12 20:07:51, cbiesinger wrote:
> Why not make this translation inside of dirtiedGrisAreas?

Because we only need to do it for columns, not for rows.
So we'd need to add an extra param to dirtiedGrisAreas()
to know if we're processing columns or rows.

Anyway I can do it, if you think it's better.

[cbiesinger, 2016-04-13 19:17:41]

On 2016/04/13 08:42:56, Manuel Rego wrote:
>
https://codereview.chromium.org/1873163002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/paint/GridPainter.cpp (right):
> 
>
https://codereview.chromium.org/1873163002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/paint/GridPainter.cpp:53: columnPositions[i] =
> m_layoutGrid.translateRTLCoordinate(columnPositions[i]);
> On 2016/04/12 20:07:51, cbiesinger wrote:
> > Why not make this translation inside of dirtiedGrisAreas?
> 
> Because we only need to do it for columns, not for rows.
> So we'd need to add an extra param to dirtiedGrisAreas()
> to know if we're processing columns or rows.
> 
> Anyway I can do it, if you think it's better.

Makes sense. lgtm.

[Manuel Rego, 2016-04-13 20:02:38]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2016-04-13 20:02:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1873163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1873163002/40001

[commit-bot: I haz the power, 2016-04-13 20:16:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 20:16:01]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Manuel Rego, 2016-04-13 20:22:52]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2016-04-13 20:23:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1873163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1873163002/40001

[commit-bot: I haz the power, 2016-04-13 21:15:27]

Description was changed from

==========
[css-grid] Fix painting in RTL

Due to the optimization we've in GridPainter that only paints
the grid items in the cells affected by the paint invalidation rect,
we've an issue using direction RTL, as the cells to be painted
were wrongly detected.

The problem is that LayoutGrid::columnPositions() is not returning
physical positions in the case of RTL, so we need to translate that
vector before calling dirtiedGridAreas().
As we're changing the order of the tracks in the new translated Vector
we need to change the GridSpan we get as result from dirtiedGridAreas().

Created a helper function LayoutGrid::translateRTLCoordinate()
and used it in the different parts of the code where we need to do
this conversion.

TEST=fast/css-grid-layout/grid-painting-rtl.html

BUG=600680
==========

to

==========
[css-grid] Fix painting in RTL

Due to the optimization we've in GridPainter that only paints
the grid items in the cells affected by the paint invalidation rect,
we've an issue using direction RTL, as the cells to be painted
were wrongly detected.

The problem is that LayoutGrid::columnPositions() is not returning
physical positions in the case of RTL, so we need to translate that
vector before calling dirtiedGridAreas().
As we're changing the order of the tracks in the new translated Vector
we need to change the GridSpan we get as result from dirtiedGridAreas().

Created a helper function LayoutGrid::translateRTLCoordinate()
and used it in the different parts of the code where we need to do
this conversion.

TEST=fast/css-grid-layout/grid-painting-rtl.html

BUG=600680
==========

[commit-bot: I haz the power, 2016-04-13 21:15:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-13 21:17:09]

Description was changed from

==========
[css-grid] Fix painting in RTL

Due to the optimization we've in GridPainter that only paints
the grid items in the cells affected by the paint invalidation rect,
we've an issue using direction RTL, as the cells to be painted
were wrongly detected.

The problem is that LayoutGrid::columnPositions() is not returning
physical positions in the case of RTL, so we need to translate that
vector before calling dirtiedGridAreas().
As we're changing the order of the tracks in the new translated Vector
we need to change the GridSpan we get as result from dirtiedGridAreas().

Created a helper function LayoutGrid::translateRTLCoordinate()
and used it in the different parts of the code where we need to do
this conversion.

TEST=fast/css-grid-layout/grid-painting-rtl.html

BUG=600680
==========

to

==========
[css-grid] Fix painting in RTL

Due to the optimization we've in GridPainter that only paints
the grid items in the cells affected by the paint invalidation rect,
we've an issue using direction RTL, as the cells to be painted
were wrongly detected.

The problem is that LayoutGrid::columnPositions() is not returning
physical positions in the case of RTL, so we need to translate that
vector before calling dirtiedGridAreas().
As we're changing the order of the tracks in the new translated Vector
we need to change the GridSpan we get as result from dirtiedGridAreas().

Created a helper function LayoutGrid::translateRTLCoordinate()
and used it in the different parts of the code where we need to do
this conversion.

TEST=fast/css-grid-layout/grid-painting-rtl.html

BUG=600680

Committed: https://crrev.com/53cea4d18b15b735c4ab6cd85cfcb3cc07593452
Cr-Commit-Position: refs/heads/master@{#387090}
==========

[commit-bot: I haz the power, 2016-04-13 21:17:10]

Patchset 3 (id:??) landed as
https://crrev.com/53cea4d18b15b735c4ab6cd85cfcb3cc07593452
Cr-Commit-Position: refs/heads/master@{#387090}