scripts/travis-build.sh - Issue 1873133003: Add travis CI config

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/travis-build.sh

Issue 1873133003: Add travis CI config (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master

Patch Set: Fix review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #!/bin/sh

	2

	3 set -ex

	4

	5 setup_env() {

	6 # Travis sets CC/CXX to the system toolchain, so our .travis.yml

	7 # exports USE_{CC,CXX} for this script to use.

	8 if test -n "$USE_CC"; then
	vapier 2016/04/11 17:13:35 more standard imo is to use [ instead of test if more standard imo is to use [ instead of test if [ -n "${USE_CC}" ]; then Ted Mielczarek 2016/04/12 10:03:06 Done. Show quoted text On 2016/04/11 17:13:35, vapier wrote: > more standard imo is to use [ instead of test > > if [ -n "${USE_CC}" ]; then Done.
	9 export CC=$USE_CC

	10 fi

	11 if test -n "$USE_CXX"; then
	vapier 2016/04/11 17:13:35 same here same here Ted Mielczarek 2016/04/12 10:03:06 Done. Show quoted text On 2016/04/11 17:13:35, vapier wrote: > same here Done.
	12 export CXX=$USE_CXX

	13 fi

	14 }

	15

	16 build() {

	17 ./configure

	18 # Use -jN for faster builds. Travis build machines under Docker

	19 # have a lot of cores, but resource limits will kill the build

	20 # if we try to use them all, so use at most 4.
	vapier 2016/04/11 17:13:35 you should reference this report: https://github. you should reference this report: https://github.com/travis-ci/travis-ci/issues/1972 it's not a core utilization issue, but more the compiler uses a lot of memory, and when you allow a lot of cores like that, the kernel starts OOM-ing. i would move this section up to setup_env and have it export like NCPUS and JOBS. that way we can allow a higher # depending on the toolchain (sounds like clang doesn't use as much memory). Ted Mielczarek 2016/04/11 17:30:17 Yeah, I understood the root cause, I may have just Show quoted text On 2016/04/11 17:13:35, vapier wrote: > you should reference this report: > https://github.com/travis-ci/travis-ci/issues/1972 > > it's not a core utilization issue, but more the compiler uses a lot of memory, > and when you allow a lot of cores like that, the kernel starts OOM-ing. Yeah, I understood the root cause, I may have just not phrased my explanation clearly. Ted Mielczarek 2016/04/12 10:03:06 Done. Show quoted text On 2016/04/11 17:13:35, vapier wrote: > you should reference this report: > https://github.com/travis-ci/travis-ci/issues/1972 > > it's not a core utilization issue, but more the compiler uses a lot of memory, > and when you allow a lot of cores like that, the kernel starts OOM-ing. > > i would move this section up to setup_env and have it export like NCPUS and > JOBS. that way we can allow a higher # depending on the toolchain (sounds like > clang doesn't use as much memory). Done.
	21 ncpus=$(getconf _NPROCESSORS_ONLN)

	22 jobs=$(($ncpus<4?$ncpus:4))
	vapier 2016/04/11 17:13:35 there's no need to omit spaces ... that just makes there's no need to omit spaces ... that just makes it harder to read. jobs=$(( ncpus < 4 ? ncpus : 4 )) Ted Mielczarek 2016/04/12 10:03:06 Done. Show quoted text On 2016/04/11 17:13:35, vapier wrote: > there's no need to omit spaces ... that just makes it harder to read. > > jobs=$(( ncpus < 4 ? ncpus : 4 )) Done.
	23 make -j${jobs} check

	24 }

	25

	26 main() {

	27 setup_env

	28 build

	29 }

	30

	31 main "$@"

OLD	NEW

« .travis.yml ('K') | « .travis.yml ('k') | scripts/travis-checkout.sh » ('j') | no next file with comments »