scripts/travis-build.sh - Issue 1873133003: Add travis CI config

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/travis-build.sh

Issue 1873133003: Add travis CI config (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #!/bin/sh

	2

	3 set -ex

	4
	vapier 2016/04/11 15:09:17 i would restructure this code a bit up front: se i would restructure this code a bit up front: setup_env() { ... mess with cc/cxx ... } build() { ./configure make .... } main() { setup_env build } main "$@" Ted Mielczarek 2016/04/11 16:30:18 Okay. I'm not a big fan of overly-complex shell sc Show quoted text On 2016/04/11 15:09:17, vapier wrote: > i would restructure this code a bit up front: Okay. I'm not a big fan of overly-complex shell scripts (I generally move to Python for anything that winds up non-trivial), but I don't care too strongly about it in this case.
	5 if test -n "$USE_CC"; then

	6 export CC=$USE_CC

	7 fi

	8 if test -n "$USE_CXX"; then

	9 export CXX=$USE_CXX

	10 fi

	11

	12 # Use -j4 for faster builds. Travis build machines under Docker
	vapier 2016/04/11 15:09:17 i've never run into this problem. i do: ncpus=$ i've never run into this problem. i do: ncpus=$(getconf _NPROCESSORS_ONLN) make -j${ncpus} we should at least calculate the value dynamically rather than hardcode 4 Ted Mielczarek 2016/04/11 16:30:18 I tried something very similar: https://github.com Show quoted text On 2016/04/11 15:09:17, vapier wrote: > i've never run into this problem. i do: > > ncpus=$(getconf _NPROCESSORS_ONLN) > make -j${ncpus} I tried something very similar: https://github.com/luser/breakpad/commit/ab5619c5250cb5f0f3a785c107ecf841afff... which made the build use `make -j32`, and it resulted in my GCC processes being killed (presumably by OOMkiller): https://travis-ci.org/luser/breakpad/builds/120983550 Show quoted text > we should at least calculate the value dynamically rather than hardcode 4 This is definitely a hack, but given that it's written to run only in the Travis environment it doesn't bother me overmuch. If I made it `min($ncpus,4)` would that be better?
	13 # have a lot of cores, but resource limits will kill the build

	14 # if we try to use them all.

	15 ./configure && make -j4 check

OLD	NEW

« .travis.yml ('K') | « .travis.yml ('k') | scripts/travis-checkout.sh » ('j') | scripts/travis-checkout.sh » ('J')