build/config/compiler/BUILD.gn - Issue 1873133002: [GN] Fix -g flags to be consistent between gyp & gn on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1873133002: [GN] Fix -g flags to be consistent between gyp & gn on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index a59907bc8ddeaeeaf1918bc2512127074eb2464e..43887fbf9ec34a76c06f0fad00da110b88f55cf9 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -1338,7 +1338,11 @@ config("symbols") {

ldflags = [ "/DEBUG" ]

}

} else {

- cflags = [ "-g2" ]

+ if (!is_ios) {

Dirk Pranke 2016/04/11 16:23:00 nit: I probably would've flipped the order of the

sdefresne 2016/04/12 11:28:34 Done.

+ cflags = [ "-g2" ]

+ } else {

+ cflags = [ "-gdwarf-2" ]

+ }

if (use_debug_fission) {

cflags += [ "-gsplit-dwarf" ]

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »