Update StickyKeys overlay to show or hide AltGr depending on the

chrome/browser/chromeos/accessibility/accessibility_manager.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ACCESSIBILITY_ACCESSIBILITY_MANAGER_H_
 #define CHROME_BROWSER_CHROMEOS_ACCESSIBILITY_ACCESSIBILITY_MANAGER_H_
 
 #include <set>
 
 #include "ash/accessibility_delegate.h"
 #include "ash/session_state_observer.h"
 #include "base/callback_list.h"
 #include "base/memory/weak_ptr.h"
 #include "base/prefs/pref_change_registrar.h"
 #include "base/time/time.h"
 #include "chrome/browser/chromeos/accessibility/accessibility_util.h"
 #include "chrome/browser/extensions/api/braille_display_private/braille_controller.h"
+#include "chromeos/ime/input_method_manager.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_system.h"
 
 namespace content {
 class RenderViewHost;
 }
 class Profile;
 
@@ skipping 31 matching lines @@
 
 typedef base::CallbackList<void(const AccessibilityStatusEventDetails&)>
     AccessibilityStatusCallbackList;
 
 typedef AccessibilityStatusCallbackList::Subscription
     AccessibilityStatusSubscription;
 
 // AccessibilityManager changes the statuses of accessibility features
 // watching profile notifications and pref-changes.
 // TODO(yoshiki): merge MagnificationManager with AccessibilityManager.
-class AccessibilityManager : public content::NotificationObserver,
-    extensions::api::braille_display_private::BrailleObserver,
-    public ash::SessionStateObserver {
+class AccessibilityManager
+    : public content::NotificationObserver,
+      public extensions::api::braille_display_private::BrailleObserver,
+      public input_method::InputMethodManager::Observer,
+      public ash::SessionStateObserver {
  public:
   // Creates an instance of AccessibilityManager, this should be called once,
   // because only one instance should exist at the same time.
   static void Initialize();
   // Deletes the existing instance of AccessibilityManager.
   static void Shutdown();
   // Returns the existing instance. If there is no instance, returns NULL.
   static AccessibilityManager* Get();
 
   // On a user's first login into a device, any a11y features enabled/disabled
   // by the user on the login screen are enabled/disabled in the user's profile.
   // This class watches for profile changes and copies settings into the user's
   // profile when it detects a login with a newly created profile.
   class PrefHandler {
    public:
     explicit PrefHandler(const char* pref_path);
     virtual ~PrefHandler();
 
     // Should be called from AccessibilityManager::SetProfile().
     void HandleProfileChanged(Profile* previous_profile,
                               Profile* current_profile);
 
    private:
     const char* pref_path_;
   };

[oshima, 2014/03/10 22:11:08]

DISALLOW_COPY_AND_ASSIGN unless it's designed to be copyable.

[Zachary Kuznia, 2014/03/11 21:01:02]

Done.

 
   // Returns true when the accessibility menu should be shown.
   bool ShouldShowAccessibilityMenu();
 
   // Returns true when cursor compositing should be enabled.
   bool ShouldEnableCursorCompositing();
 
   // Enables or disables the large cursor.
   void EnableLargeCursor(bool enabled);
   // Returns true if the large cursor is enabled, or false if not.
@@ skipping 102 matching lines @@
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
   // extensions::api::braille_display_private::BrailleObserver implementation.
   // Enables spoken feedback if a braille display becomes available.
   virtual void OnDisplayStateChanged(
       const extensions::api::braille_display_private::DisplayState&
           display_state) OVERRIDE;
 
+  // Overridden from InputMethodManager::Observer.

[oshima, 2014/03/10 22:11:08]

nit: You can now just say

// InputMethodManager::Observer

without "overridden"/"implementation".

Can you also remove "implementation:" in Observe?

[Zachary Kuznia, 2014/03/11 21:01:02]

Done.

+  virtual void InputMethodChanged(input_method::InputMethodManager* manager,
+                                  bool show_message) OVERRIDE;
+
+
   // Profile which has the current a11y context.
   Profile* profile_;
 
   // Profile which ChromeVox is currently loaded to. If NULL, ChromeVox is not
   // loaded to any profile.
   bool chrome_vox_loaded_on_lock_screen_;
   bool chrome_vox_loaded_on_user_screen_;
 
   content::NotificationRegistrar notification_registrar_;
   scoped_ptr<PrefChangeRegistrar> pref_change_registrar_;
@@ skipping 24 matching lines @@
   bool system_sounds_enabled_;
 
   AccessibilityStatusCallbackList callback_list_;
 
   DISALLOW_COPY_AND_ASSIGN(AccessibilityManager);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_ACCESSIBILITY_ACCESSIBILITY_MANAGER_H_