Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1873123002: Update woff2 to 4e698b8 (Closed)

Created:
4 years, 8 months ago by Takashi Toyoshima
Modified:
4 years, 8 months ago
Reviewers:
Kunihiko Sakamoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update woff2 to 4e698b8 This will fix an OTS parsing error case on WOFF2 font. BUG=601240 Committed: https://crrev.com/116d7b0ac70c354ee5f863afe616ea8588a1d48c Cr-Commit-Position: refs/heads/master@{#386643}

Patch Set 1 #

Patch Set 2 : assert.h #

Total comments: 1

Patch Set 3 : mac build #

Patch Set 4 : merge #

Patch Set 5 : update BUILD.gn (win8 build fix?) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1075 lines, -419 lines) Patch
M third_party/woff2/BUILD.gn View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
A third_party/woff2/CONTRIBUTING.md View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/woff2/Makefile View 3 chunks +7 lines, -2 lines 0 comments Download
M third_party/woff2/README.chromium View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/woff2/README.md View 1 chunk +1 line, -1 line 0 comments Download
M third_party/woff2/src/file.h View 2 chunks +9 lines, -7 lines 0 comments Download
M third_party/woff2/src/font.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/woff2/src/font.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/woff2/src/glyph.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/woff2/src/port.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/woff2/src/store_bytes.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/woff2/src/table_tags.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/woff2/src/transform.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/woff2/src/transform.cc View 1 chunk +127 lines, -0 lines 0 comments Download
M third_party/woff2/src/woff2_common.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/woff2/src/woff2_common.cc View 2 chunks +12 lines, -1 line 0 comments Download
M third_party/woff2/src/woff2_compress.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/woff2/src/woff2_dec.h View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/woff2/src/woff2_dec.cc View 23 chunks +606 lines, -349 lines 0 comments Download
M third_party/woff2/src/woff2_decompress.cc View 2 chunks +12 lines, -18 lines 0 comments Download
M third_party/woff2/src/woff2_enc.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/woff2/src/woff2_enc.cc View 11 chunks +35 lines, -21 lines 0 comments Download
A third_party/woff2/src/woff2_out.h View 1 chunk +114 lines, -0 lines 0 comments Download
A third_party/woff2/src/woff2_out.cc View 1 chunk +73 lines, -0 lines 0 comments Download
M third_party/woff2/woff2.gyp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873123002/40001
4 years, 8 months ago (2016-04-12 06:58:33 UTC) #2
Takashi Toyoshima
This will pass the builds. Can you take a look? Seems like we can not ...
4 years, 8 months ago (2016-04-12 07:22:22 UTC) #4
Takashi Toyoshima
Sorry, the PS3 didn't include minor changes from linux. PS4 contains it.
4 years, 8 months ago (2016-04-12 07:41:15 UTC) #5
Kunihiko Sakamoto
lgtm if bots are happy
4 years, 8 months ago (2016-04-12 07:48:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873123002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873123002/80001
4 years, 8 months ago (2016-04-12 10:10:10 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-12 10:19:30 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 10:21:06 UTC) #12
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/116d7b0ac70c354ee5f863afe616ea8588a1d48c
Cr-Commit-Position: refs/heads/master@{#386643}

Powered by Google App Engine
This is Rietveld 408576698